-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Horizontally scrolling tables in list view - pull request potential? #2272
Comments
@mshibuya do you have thoughts on this? Or should I discuss it with someone else? Thanks! |
It should definitely be included as an option for the gem, would make a lot of sense! |
@sbull I have used your javascript code, and that kind of result I have got: It "destroys" table. |
+1 on including it with rails_admin per default |
+1 for including it with Rails but I think it should be optional in the config. The JS should also add some classes to the wrapper elements so it's easily to customise the look. |
+1 on including it with rails_admin as optional in the config! |
…mns and frozen row headers instead of paginated sets Addresses Issue railsadminteam#2272.
…mns and frozen row headers instead of paginated sets Addresses Issue railsadminteam#2272.
…mns and frozen row headers instead of paginated sets Addresses Issue railsadminteam#2272.
…mns and frozen row headers instead of paginated sets Addresses Issue railsadminteam#2272.
…mns and frozen row headers instead of paginated sets Addresses Issue railsadminteam#2272.
I have created PR #3017 to add this feature and updated the wiki with a new workaround. |
…mns and frozen row headers instead of paginated sets Addresses Issue railsadminteam#2272.
#3017 was merged in. |
I recently worked out a way to make the "list" view tables more useful to me - showing more/all columns with horizontal scrolling and frozen header columns, as I described here: https://github.com/sferik/rails_admin/wiki/Horizontally-scrolling-table-with-frozen-columns-in-list-view
It's mostly done in javascript, but could be better suited to be integrated in the gem instead.
I'm wondering if there would be support for making this a configuration option. If the feature would likely be accepted, I'll work on a pull request for it. I'm sure I'll need some guidance along the way - such as naming for the config option, how to build a test case, etc. Should I take a crack at this, or do you think it's better to live in userland customization instead of in the gem?
The text was updated successfully, but these errors were encountered: