Skip to content

Respect implicit encoding of thorfiles #782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

timdiggins
Copy link
Contributor

🌈 fixes #776

@timdiggins
Copy link
Contributor Author

PS this has the #780 PR in it - will need to rebase once it has been merged.

@timdiggins timdiggins mentioned this pull request Mar 10, 2022
@timdiggins timdiggins force-pushed the respect-implicit-encoding-of-thorfiles branch from 9f46c83 to c4f445e Compare June 16, 2022 17:01
@timdiggins
Copy link
Contributor Author

@dorner @deivid-rodriguez I've rebased this on main, now it's (mostly) green

@rafaelfranca rafaelfranca merged commit 8c9817d into rails:main Jun 17, 2022
@timdiggins timdiggins deleted the respect-implicit-encoding-of-thorfiles branch June 17, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

thor files have default encoding of ASCII-8BIT, not UTF-8
3 participants