Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Organize matrix to run something #125

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

CI: Organize matrix to run something #125

wants to merge 4 commits into from
+29 −30

Conversation

olleolleolle
Copy link

@olleolleolle olleolleolle commented May 27, 2021 •
edited
Loading

This PR configures the build matrix to include newer versions of Rails.

  • use an explcitly defined build matrix
  • run Ruby 2.2-2.4 with Sprockets 3 on Rails 5.2, still works
  • Remove rbx-3 - can not install

TODO

  • Sprockets 4 support
  • OR: Fail on Sprockets 4 support needed for the newer versions, move those to "allow failures"?

Other

Found a tiny issue, and extract its fix to #126.

@olleolleolle
Copy link
Author

Or, is the better goal to work towards a Sprockets 4 configuration which works?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@olleolleolle