Added a (failing) test for when inflecting API #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome. Would be cool if someone pick this up and fix it on the same PR so I'm flaging it as |
|
@joaomdmoura I could only think of two solutions to this: 1) temporarily turn off the inflections 2) change how we look up adapters 3) don't use the inflector So, I took a stab at making adapters registrable (since I don't really like the hard-coding adapter constant names) rmcfadzean#1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failing test as per #993.
Not overly sure how to fix this though. Could potentially fail on other inflections too like json -> JSON.