Feature/adapter #612
Merged
Feature/adapter #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
August 27, 2014 08:21
* Introduce abstract Adapter class * Organaze test structure to match convemtions
* Get adapter instance using ActiveModel::Serializer::Adapter.adapter_for(serializer)
| @@ -84,5 +103,9 @@ def attributes | |||
| hash[name] = send(name) | |||
| end | |||
| end | |||
|
|
|||
| def associations | |||
| self.class._associations.dup | |||
* Tests for ArraySerializer
This reverts commit 85b4b85.
|
@steveklabnik I think it's time to merge since PR become to big. It is not complete yet, but i'm going to keep working. |
|
Sounds good! I like where this is going, and it doesn't have to be perfect just quite yet. Let's merge this in and keep working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapter configuration using AMS.config. It may be configured with a class or symbol:
Start to work on JsonApi adapter to better understand interface between adapters and serializers.
Rename null adapter to json adapter. Null adapter always return empty hash now.
Introduce ArraySerializer.
Add a lot of tests.
I would be glad to receive any feedback.