Reevaluation of object #2307
Merged
Reevaluation of object #2307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bf4
reviewed
Jan 8, 2019
| @@ -11,7 +11,8 @@ def reflection_options | |||
| end | |||
|
|
|||
| def object | |||
| @object ||= reflection.value( | |||
| return @object if defined?(@object) | |||
| @object = reflection.value( | |||
There was a problem hiding this comment.
looks fine to me. I write code like this all the time.
mind adding an entry to the changelog under fixes?
faucct
force-pushed
the
bugfix/double-evaluation-of-object
branch
from
34ee253 to
a39794d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Object gets reevaluated when
valueisnilorfalse. I don't know where to put a test on this.