Eagerload on application boot #2289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Looks like there was a change in minitest run_one_method |
|
@bf4 thanks for taking a look at it. Seems like there happend some backwards incompatible change in minitest unreleated to this PR. This issue rails/rails-perftest#43 seems to be releated. |
|
I've fixed CI. might rebasing and re-running CI? |
Using ActiveModelSerializers with a threaded web server eg. Puma uninitialized constant errors are thrown. Leaving this article for reference: http://blog.plataformatec.com.br/2012/08/eager-loading-for-greater-good/.
|
Yay it's green 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Load all modules and classes during application boot. This is needed because rails 5 unhooks autoloading (rails/rails@a71350c) after the application has booted.
Changes
Eagerload dependencies during application boot by using
eager_autoload.Related GitHub issues
#2255
Additional helpful information
Not sure if eagerloading
ActiveModelSerializers::Adapter::JsonApishould be the default or the user has to add explicitlyconfig.eager_load_namespaces << ActiveModelSerializers::Adapter::JsonApito reduce memory usage if another adapter is used.