JSON:API relationship tests no longer show v0.10.5 regression #2211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bf4
force-pushed
the
polymorphic_relationships_require_serializer_instance
branch
from
20afea3 to
398b5fa
Compare
bf4
commented
Oct 30, 2017
| if association.polymorphic? | ||
| # We can't infer resource type for polymorphic relationships from the serializer. | ||
| # We can ONLY know a polymorphic resource type by inspecting each resource. | ||
| association.lazy_association.serializer.json_key |
There was a problem hiding this comment.
cc @furkanayhan @andyhite @rmachielse @burmashave @Rio517 @MidnightWonderer @cassidycodes Fixes #2160
bf4
commented
Oct 30, 2017
| JsonApi.send(:transform_key_casing!, raw_type, transform_options) | ||
| end | ||
|
|
||
| def self.for_type_with_id(type, id, options) | ||
| return nil if id.blank? | ||
| type = inflect_type(type) |
bf4
commented
Oct 30, 2017
| @@ -165,6 +165,53 @@ def test_json_api_serialization | |||
|
|
|||
| assert_equal(expected, serialization(@picture, :json_api)) | |||
| end | |||
|
|
|||
| def test_json_api_serialization_with_polymorphic_belongs_to | |||
There was a problem hiding this comment.
I added this test and ran it against the v0.10.5 tag and it passed. I then worked on 0-10-stable until it passed again
bf4
commented
Oct 30, 2017
| @@ -89,7 +89,7 @@ class ObjectTag < ActiveRecord::Base | |||
| end | |||
| class PolymorphicObjectTagSerializer < ActiveModel::Serializer | |||
| attributes :id | |||
| has_many :taggable, serializer: PolymorphicSimpleSerializer, polymorphic: true | |||
| belongs_to :taggable, serializer: PolymorphicSimpleSerializer, polymorphic: true | |||
There was a problem hiding this comment.
Not sure why the belongs_to relationships was specified with a has_many serializer method here and in the PolymorphicBelongsToSerializer below. But this change surfaces the bug reported in #2160
Should Serializer._type ever be inflected? Right now, it won't be, but association.serializer._type will be inflected. That's the current behavior.
bf4
force-pushed
the
polymorphic_relationships_require_serializer_instance
branch
from
398b5fa to
a0de45a
Compare
|
LGTM 👍 |
This was referenced Oct 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2160
Closes #2125
Related: #2140