Update version constraint for jsonapi-renderer

[tagliala]

Purpose

Update 'jsonapi-renderer' dependency to meet last released version

Changes

Just the 'jsonapi-renderer' entry in the gemspec file

Caveats

Related GitHub issues

#2057

Additional helpful information

Tested against Rails: 5.1.4, 5.0.6, 4.2.9, 4.1.16

[tagliala]

Failures depend on a RuboCop offence which was not introduced in this PR:

https://travis-ci.org/rails-api/active_model_serializers/jobs/276495964#L789

Offenses:
lib/active_model/serializer.rb:340:30: C: Style/SpaceInsideBlockBraces: Space inside empty braces detected.
      return Enumerator.new { } unless object
                             ^
157 files inspected, 1 offense detected

[bf4]

What's different from the 0.1.x series to 0.2.x? This looks like it may be a breaking change and should just be changing < 0.2 to < 0.3

[tagliala]

Hi,

unfortunately they don't release a changelog :\

I've just noticed that my bundle is out of date according to bundle outdated.

I've checked some commits, but I'm not confident in saying if there is a breaking change or not: https://github.com/jsonapi-rb/jsonapi-renderer/commits/master

I could go for ['>= 0.1.1.beta1', '< 0.3'] if you prefer

[beauby]

Author here – it is safe to upgrade the dependency as 1. the 0.2 series is backwards compatible with the 0.1 series and 2. no AMS-used code was changed.

[bf4]

sure

…

On Sun, Sep 17, 2017 at 1:05 PM, Geremia Taglialatela < ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In active_model_serializers.gemspec <#2189 (comment)> : > @@ -42,7 +42,7 @@ Gem::Specification.new do |spec| # 'minitest' # 'thread_safe' - spec.add_runtime_dependency 'jsonapi-renderer', ['>= 0.1.1.beta1', '< 0.2'] + spec.add_runtime_dependency 'jsonapi-renderer', '~> 0.2.0' Hi, unfortunately they don't release a changelog :\ I've just noticed that my bundle is out of date according to bundle outdated and I was checking why. I've checked some commits, but I'm not confident in saying if there is a breaking change or not: https://github.com/jsonapi-rb/ jsonapi-renderer/commits/master I could go for ['>= 0.1.1.beta1', '< 0.3'] if you prefer — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2189 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAIuQhwXmjDW_lgAfl6GCQvSJVAohh0eks5sjV9pgaJpZM4PaISW> .

[tagliala]

PR updated

[beauby]

This is the same as ~> 0.2.0, except it also allows the 0.1 series. Any specific reason?

[tagliala]

@beauby maybe I didn't get this comment: #2189 (review)

in response to: #2189 (comment)

[beauby]

I'm not sure what @bf4 meant there either (:

[bf4]

@beauby I thought it would be a breaking change to AMS to change the minimum jsonapi-renderer version. Am I wrong there?

[beauby]

Oh right – yeah then ['>= 0.1.1.beta1', '< 0.3'] LGTM.

[tagliala]

Should I do something else on my side?

[beauby]

@taglia No, I think we're good. @bf4?

[bf4]

@tagliala Are you comfortable rebasing against 0-10-stable and force pushing to your branch?

[tagliala]

Done, everything is green 💪