Return null resource object identifier for blank id #2119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, fix test where attributes were included when id was ""
```
1) Failure:
ActionController::Serialization::AdapterSelectorTest#test_render_using_adapter_override
[test/action_c$ntroller/adapter_selector_test.rb:53]:
--- expected
+++ actual
@@ -1 +1 @@
-"{\"data\":{\"id\":\"\",\"type\":\"profiles\",\"attributes\":{\"name\":\"Name 1\",\"description\":\"Description 1\"}}}"
+"{\"data\":null}"
```
bf4
commented
May 1, 2017
| @@ -295,20 +295,8 @@ def attributes_for(serializer, fields) | |||
|
|
|||
| # {http://jsonapi.org/format/#document-resource-objects Document Resource Objects} | |||
| def resource_object_for(serializer, include_slice = {}) | |||
| resource_object = serializer.fetch(self) do | |||
There was a problem hiding this comment.
refactored to data_for to decrease method size, per style
bf4
commented
May 1, 2017
| @@ -322,7 +310,10 @@ def resource_object_for(serializer, include_slice = {}) | |||
| # prs: | |||
| # https://github.com/rails-api/active_model_serializers/pull/1247 | |||
| # https://github.com/rails-api/active_model_serializers/pull/1018 | |||
| resource_object[:links] = links if links.any? | |||
| if (links = links_for(serializer)).any? | |||
| resource_object ||= {} | |||
|
what if i want to serialize an object via json_api adapter that doesn't have an ID? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix regression from 6e41528 where relationships with null data shows up with
:data=>{:id=>"", :type=>"locations"}Also, fix test where attributes were included when id was ""