Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This adds namespace lookup to serializer_for #1968

Merged
merged 12 commits into from
Nov 9, 2016
Merged

This adds namespace lookup to serializer_for #1968

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e529466
This adds namespace lookup to serializer_for
NullVoxPopuli May 30, 2016
3c98d48
address rubocop issue
NullVoxPopuli Nov 8, 2016
526738b
address @bf4's feedback
NullVoxPopuli Nov 8, 2016
771af73
add docs
NullVoxPopuli Nov 8, 2016
81e743a
update docs, add more tests
NullVoxPopuli Nov 8, 2016
44b06a3
apparently rails master doesn't have before filter
NullVoxPopuli Nov 8, 2016
aaa94af
try to address serializer cache issue between tests
NullVoxPopuli Nov 8, 2016
c847e63
update cache for serializer lookup to include namespace in the key, a…
NullVoxPopuli Nov 8, 2016
eb630e8
update docs, and use better cache key creation method
NullVoxPopuli Nov 8, 2016
0fa8196
update docs [ci skip]
NullVoxPopuli Nov 8, 2016
29d14a8
update docs [ci skip]
NullVoxPopuli Nov 8, 2016
679ed72
add to changelog [ci skip]
NullVoxPopuli Nov 8, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
address rubocop issue
  • Loading branch information
@NullVoxPopuli
NullVoxPopuli committed Nov 8, 2016
commit 3c98d489cd19f87619c707d5e2ba6651a3d97989
2 changes: 0 additions & 2 deletions test/serializers/serializer_for_with_namespace_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
require 'test_helper'



module ActiveModel
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. needs controller test for implicit lookup as well as option passing, which is really covered below, here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor Author

@NullVoxPopuli NullVoxPopuli Nov 8, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests added

class Serializer
class SerializerForWithNamespaceTest < ActiveSupport::TestCase
Expand Down