Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Rails 4.0 and Ruby 2.0.0 #1662

Merged
merged 1 commit into from
Apr 4, 2016
Merged

Drop support for Rails 4.0 and Ruby 2.0.0 #1662

merged 1 commit into from
Apr 4, 2016

Conversation

remear
Copy link
Member

@remear remear commented Apr 4, 2016

Purpose

Drop Ruby 2.0.0 support. Drop Rails 4.0 support.

https://www.ruby-lang.org/en/news/2016/02/24/support-plan-of-ruby-2-0-0-and-2-1/
http://guides.rubyonrails.org/maintenance_policy.html

Changes

  • Remove 2.0.0 from travis
  • Remove Rails 4.0 from travis
  • Tidy code paths based on Rails versions
  • Remove minitest 4/5 conditions.

Additional helpful information

  • The arity tests seem to behave differently than the comments indicate.
  • render(plain: 'ok') seems to work fine with Rails 4.1. The conditional said > when perhaps it meant >= or > '4.0'

@NullVoxPopuli
Copy link
Contributor

I approve of this. @bf4 ?

@bf4
Copy link
Member

bf4 commented Apr 4, 2016

Only question is before or after rc5. how about rc5, drop it, then rc6?

@remear
Copy link
Member Author

remear commented Apr 4, 2016

I'd like it merged after the release of rc5.

@NullVoxPopuli
Copy link
Contributor

it's after rc5!

@NullVoxPopuli NullVoxPopuli merged commit 74d172b into rails-api:master Apr 4, 2016
@bf4 bf4 mentioned this pull request Apr 5, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@remear @NullVoxPopuli @bf4