Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

organize badges #1564

Merged
merged 1 commit into from
Mar 8, 2016
Merged

organize badges #1564

merged 1 commit into from
Mar 8, 2016

Conversation

NullVoxPopuli
Copy link
Contributor

Purpose

Badges need to be organized a bit better.

Changes

only to readme

Caveats

Related GitHub issues

#1551

@NullVoxPopuli NullVoxPopuli force-pushed the organize-badges branch 2 times, most recently from 566e3d6 to 3afe177 Compare March 8, 2016 18:02
styling updates

remove styles, as github doesn't allow them
@groyoh
Copy link
Member

groyoh commented Mar 8, 2016

💯

@remear
Copy link
Member

remear commented Mar 8, 2016

Looks good.

remear added a commit that referenced this pull request Mar 8, 2016
@remear remear merged commit c97a80d into rails-api:master Mar 8, 2016
@groyoh
Copy link
Member

groyoh commented Mar 8, 2016

Changelog was forgotten 😉

@NullVoxPopuli
Copy link
Contributor Author

Did we really need it for something like this?

On Tue, Mar 8, 2016, 4:34 PM Yohan Robert [email protected] wrote:

Changelog was forgotten [image: 😉]


Reply to this email directly or view it on GitHub
#1564 (comment)
.

@groyoh
Copy link
Member

groyoh commented Mar 8, 2016

My bad, I thought that this PR also added the codebeat badge. But I assume that #1551 should have had an entry in the CHANGELOG stating that we added codebeat, right?

@remear
Copy link
Member

remear commented Mar 8, 2016

I figured the CHANGELOG was more for the proejct's code changes and this was just a tooling addition. Travis is mentioned in there though, so sure, it could use a CHANGELOG entry.

@bf4 bf4 deleted the organize-badges branch March 8, 2016 22:28
@bf4
Copy link
Member

bf4 commented Mar 8, 2016

@remear @groyoh some of the changelog was auto-generated and not gardened. I also like to give non-maintainers credit for their work in it.

@groyoh
Copy link
Member

groyoh commented Mar 8, 2016

@remear an entry for tooling could also be an easy way to figure out why this tool was added in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants