Refactor fragment cache methods #1527
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groyoh
force-pushed
the
refactor_fragment_cache
branch
2 times, most recently
from
3f9d26c to
fac4521
Compare
| @@ -23,7 +23,8 @@ Fixes: | |||
| - [#1501](https://github.com/rails-api/active_model_serializers/pull/1501) Adds tests for SerializableResource::use_adapter?,doc typos (@domitian) | |||
| - [#1488](https://github.com/rails-api/active_model_serializers/pull/1488) Require ActiveSupport's string inflections (@nate00) | |||
|
|
|||
| Misc: | |||
| Misc | |||
|
Looks awesome! |
groyoh
force-pushed
the
refactor_fragment_cache
branch
from
fac4521 to
8276f0a
Compare
|
@groyoh would love you to also look at
|
| def cached_attributes(klass, serializers) | ||
| attributes = serializer.class._attributes | ||
| cached_attributes = (klass._cache_only) ? klass._cache_only : attributes.reject { |attr| klass._cache_except.include?(attr) } | ||
| def cached_attributes(serializers) |
There was a problem hiding this comment.
looks like this method should really be called cache_attributes as it is neither idempotent nor does it is a Query; rather it is a Command
There was a problem hiding this comment.
and I suppose these are really something like fragmented_serializers
There was a problem hiding this comment.
Completely agree on this. 👍
|
needs rebase :-) |
groyoh
force-pushed
the
refactor_fragment_cache
branch
from
8276f0a to
05a5b87
Compare
:) |
|
Damn, I'm conflicting with myself now 😄 |
groyoh
force-pushed
the
refactor_fragment_cache
branch
from
05a5b87 to
20a2cf3
Compare
|
Rebased again :) |
groyoh
force-pushed
the
refactor_fragment_cache
branch
from
20a2cf3 to
fcdbaa5
Compare
Removed extra calls to constantize and DRY'd the code.
groyoh
force-pushed
the
refactor_fragment_cache
branch
from
fcdbaa5 to
580139f
Compare
|
Damn I messed up with this one, will reopen when I fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed extra calls to constantize and DRY'd the code.