[0.8-stable] additional documentation for POROs #1503
Conversation
| @@ -45,18 +45,35 @@ the serializer generator: | |||
| $ rails g serializer post | |||
| ``` | |||
|
|
|||
| ### Support for PORO's and other ORM's. | |||
There was a problem hiding this comment.
Hi @feministy I'm curious if you have a reference for this grammatical change or if it's just what you're used to. I prefer the current state, myself, but I believe there's no consensus, right?
There was a problem hiding this comment.
it's what i'm used to - apostrophe's signal possession or a contraction, not a plural. i can swap back if it would be confusing to users!
There was a problem hiding this comment.
Apparently, it's a matter of some debate, but your emendation is 'more correct'. https://english.stackexchange.com/questions/55970/plurals-of-acronyms-letters-numbers-use-an-apostrophe-or-not
There was a problem hiding this comment.
i love that you can be more correct about something so tiny 😂 grammar is so cooool
|
@feministy Thanks! 👍 Looks great! Just one comment and would you like to add yourself to the changelog? |
|
@bf4 can do! sorry i missed that - will update this evening and push back up. thanks for the quick review! 😄 |
|
@bf4 updated the changelog as requested under "unreleased" - let me know if that needs to be moved to a different header |
[0.8-stable] additional documentation for POROs
|
Thanks... If you want a few more prs the changelog for 08 is lacking info that's in mastee iirc, also 09 - onmephone |
hey pals! 👋
i know, i know, it's not documentation for master 😞, but still, it's documentation! 😄
it's mostly clarification on when you need to take additional steps to use AM:S with POROs/alternative ORMs, along with a small example to show how to implement the required steps to use it. (ok, i also removed the apostrophes, you caught me)
well, you can just read it on the next tab☺️
let me know if you'd like any changes or adjustments here and i'm happy to do so!