Added testcases for serializable_resource and fixed a documentation error regarding adapter key constant #1501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domitian
changed the title
| @@ -64,7 +64,7 @@ Details: | |||
| 1. **ActionController::Serialization** | |||
| 1. `serializable_resource = ActiveModel::SerializableResource.new(resource, options)` | |||
| 1. `options` are partitioned into `adapter_opts` and everything else (`serializer_opts`). | |||
| The adapter options keys for the are defined by `ADAPTER_OPTIONS`. | |||
| The adapter_opt keys are defined in `ActiveModel::SerializableResource::ADAPTER_OPTION_KEYS`. | |||
|
@bf4 done, removed the additional testcase. |
|
Alright, squash commits, add yourself to the top of the fixes changelog and looks good to merge |
domitian
force-pushed
the
testcases-documentation-fix
branch
from
42d329b to
f1de1bf
Compare
|
@bf4 done. |
|
@domitian Thanks. Commit message is a little long, but is ok. For a laugh at an egregious offender, see http://stopwritingramblingcommitmessages.com/ :) |
| @@ -23,5 +23,13 @@ def test_serializable_resource_delegates_as_json_to_the_adapter | |||
| options = nil | |||
| assert_equal @adapter.as_json(options), @serializable_resource.as_json(options) | |||
| end | |||
|
|
|||
| def test_use_adapter_with_adapter_option | |||
| assert_equal ActiveModel::SerializableResource.new(@resource, { adapter: 'json' }).use_adapter?, true | |||
There was a problem hiding this comment.
oh, missed the expectation here. it's assert_equal(expected, actual). But in this case, since it's boolean, it should just be assert and in the next test refute
domitian
force-pushed
the
testcases-documentation-fix
branch
from
f1de1bf to
b8016da
Compare
|
@bf4 Made the changes suggested(reduced the commit message length, using refute and assert in boolean cases. |
for SerializableResource::use_adapter?
domitian
force-pushed
the
testcases-documentation-fix
branch
from
b8016da to
68f09e5
Compare
|
I think this is done and ready to be merged. |
bf4
added a commit
that referenced
this pull request
Feb 8, 2016
Added testcases for serializable_resource and fixed a documentation error regarding adapter key constant
|
Yay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a documentation error regarding adapter key constant, added a new test cases for use_adapter? method in serializable resource object and fixed a documentation typo.