Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify cache key to prevent errors and incorrect data returned. Fixes #1344 #1346

Closed
wants to merge 24 commits into from
Closed

Modify cache key to prevent errors and incorrect data returned. Fixes #1344 #1346

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
633ce52
When caching, return the object's cache_key up front if it's defined.…
kevintyll Nov 25, 2015
7d67884
Add original design doc from 0.8
bf4 Dec 21, 2015
24549b2
Update CHANGELOG from 0.8
bf4 Dec 21, 2015
965e846
Add CHANGELOG from 0.9
bf4 Dec 21, 2015
fd98349
Add some pre-history [ci skip]
bf4 Dec 21, 2015
d7de53c
Consider evaluating association in serializer context
bf4 Dec 16, 2015
ee0283c
Simplify attributes handling.
beauby Dec 10, 2015
1d4b27f
Improve attribute value computation.
beauby Dec 20, 2015
7d24cbf
Extract latent Attribute object.
beauby Dec 27, 2015
a586a45
Remove `key` from `Attribute` class.
beauby Dec 29, 2015
77095f2
Add ActiveSupport::Autoload extension to Attribute.
beauby Dec 30, 2015
ccb05f1
Add changelog.
beauby Dec 30, 2015
df594c6
Merge pull request #1410 from georgemillo/patch-1
bf4 Dec 31, 2015
b51a432
Merge pull request #1370 from beauby/simplify-attributes
bf4 Jan 4, 2016
81b1654
Merge pull request #1388 from bf4/restore_docs_from_older_releases
bf4 Jan 4, 2016
41ae5f7
Add 1356 to changelog; given credit for 1336
bf4 Jan 4, 2016
7d4f0c5
Merge branch 'bf4-consider_association_blocks'
bf4 Jan 4, 2016
f2dea8e
Have the adapter define it's own name from the class. This causes re…
kevintyll Jan 5, 2016
1a4eec4
When caching, return the object's cache_key up front if it's defined.…
kevintyll Nov 25, 2015
744c390
Have the adapter define it's own name from the class. This causes re…
kevintyll Jan 5, 2016
8f787b2
Changing the register signature back. Leaving the name implementatio…
kevintyll Jan 6, 2016
7a5759a
Changes per code review.
kevintyll Jan 6, 2016
f89ed71
Merge remote-tracking branch 'origin/master'
kevintyll Jan 6, 2016
6842e64
Fix bad merge.
kevintyll Jan 6, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add 1356 to changelog; given credit for 1336
  • Loading branch information
@bf4
bf4 committed Jan 4, 2016
commit 41ae5f7b6f254ae849f2c3fbacc49ac909185bb0
12 changes: 11 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,17 @@ Breaking changes:

Features:

- [#1336](https://github.com/rails-api/active_model_serializers/pull/1336) Added support for Grape >= 0.13, < 1.0
- [#1356](https://github.com/rails-api/active_model_serializers/pull/1356) Add inline syntax for
attributes and associations (@bf4 @beauby @noahsilas)
* Allows defining attributes so that they don't conflict with existing methods. e.g. `attribute
:title do 'Mr. Topum Hat' end`
* Allows defining associations so that they don't conflict with existing methods. e.g. `has_many
:titles do customers.pluck(:title) end`
* Allows dynamic associations, as compared to compare to using
[`virtual_value`](https://github.com/rails-api/active_model_serializers/pull/1356#discussion_r47146466).
e.g. `has_many :reviews, virtual_value: [{ id: 1 }, { id: 2 }]`
* Removes dynamically defined methods on the serializer
- [#1336](https://github.com/rails-api/active_model_serializers/pull/1336) Added support for Grape >= 0.13, < 1.0 (@johnhamelink)
- [#1291](https://github.com/rails-api/active_model_serializers/pull/1291) Add logging (@maurogeorge)
- [#1225](https://github.com/rails-api/active_model_serializers/pull/1225) Better serializer lookup, use nested serializer when it exists (@beauby)
- [#1172](https://github.com/rails-api/active_model_serializers/pull/1172) Better serializer registration, get more than just the first module (@bf4)
Expand Down