Add PORO serializable base class: ActiveModelSerializers::Model

[bf4]

Extracted from #1260

[NullVoxPopuli]

if we make attributes a hash with indifferent access, we wouldn't need this || check.
I just think it's a little weird to only have indifferent access for the id.

[bf4]

I was going to explain it but now I'm not sure

B mobile phone

On Oct 15, 2015, at 6:22 AM, L. Preston Sego III [email protected] wrote:

In lib/active_model_serializers/model.rb:

• def id

•  attributes.fetch(:id) { self.class.name.downcase }
  

• end

• Defaults to the downcased model name and updated_at

• def cache_key

•  attributes.fetch(:cache_key) { "#{self.class.name.downcase}/#{id}-#{updated_at.strftime("%Y%m%d%H%M%S%9N")}" }
  

• end

• Defaults to the time the serializer file was modified.

• def updated_at

•  attributes.fetch(:updated_at) { File.mtime(**FILE**) }
  

• end

• def read_attribute_for_serialization(key)

•  if key == :id || key == 'id'
  

  if we make attributes a hash with indifferent access, we wouldn't need this || check.
  I just think it's a little weird to only have indifferent access for the id.

—
Reply to this email directly or view it on GitHub.

[bf4]

For reasons I don't recall there might be an id method but not and :id attribute but it still hits method_missing...

[bf4]

I'm going to merge this so people can being using it, even though there's some followup

• Add PORO serializable base class: ActiveModelSerializers::Model #1272 (comment)
• Add PORO serializable base class: ActiveModelSerializers::Model #1272 (comment)
• Add PORO serializable base class: ActiveModelSerializers::Model #1272 (comment)
• Add changelog