Delegate Serializer.attributes to Serializer.attribute #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| define_method attr do | ||
| object && object.read_attribute_for_serialization(attr) | ||
| end unless method_defined?(attr) || _fragmented.respond_to?(attr) | ||
| attribute(attr) |
bf4
force-pushed
the
simplify_serializer_attributes
branch
from
f886c2a to
0504ad5
Compare
| @_attributes_keys[attr] = { key: key } if key != attr | ||
| @_attributes << key unless @_attributes.include?(key) | ||
| self._attributes_keys[attr] = { key: key } if key != attr | ||
| self._attributes << key unless self._attributes.include?(key) |
There was a problem hiding this comment.
I think this second use of _attributes violates the reference @beauby linked.... but I think it makes sense here.... so... :-\
There was a problem hiding this comment.
what was fixed? (maybe I'm just missing it?)
self._attributes << key unless self._attributes.include?(key)
but, is this -----------------------------> ^ self supposed to be here?
|
needs rebase |
bf4
force-pushed
the
simplify_serializer_attributes
branch
from
0504ad5 to
27812a1
Compare
bf4
force-pushed
the
simplify_serializer_attributes
branch
from
27812a1 to
484426c
Compare
NullVoxPopuli
added a commit
that referenced
this pull request
Sep 18, 2015
Delegate Serializer.attributes to Serializer.attribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.