Add ActiveRecord-backed fixtures. #1105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| has_many :comments | ||
| belongs_to :author | ||
| url :comments |
There was a problem hiding this comment.
Didn't someone suggest a convention for fixtures of something like
class Post < AR::Base
# stuff
class PostSerializer < AM::Serializer
# stuff
end
end
|
👍 except master doesn't have activerecord nor sqlite, right? |
|
You're obviously right! |
|
It sort of does by accident in dev... which is why I made #1090 |
beauby
force-pushed
the
add-activerecord-fixtures
branch
from
d3d3878 to
e870f73
Compare
|
Fixed the deps. |
beauby
force-pushed
the
add-activerecord-fixtures
branch
2 times, most recently
from
6470195 to
86b9aef
Compare
beauby
force-pushed
the
add-activerecord-fixtures
branch
from
86b9aef to
83f11ac
Compare
| gem 'activerecord' | ||
| gem 'sqlite3', platform: :ruby | ||
| gem 'activerecord-jdbcsqlite3-adapter', platform: :jruby | ||
| end |
There was a problem hiding this comment.
you're probably right that all the rails stuff above should be in a gem :test group..
|
Cool @beauby this will be really helpful into new feature cc/ @NullVoxPopuli |
joaomdmoura
added a commit
that referenced
this pull request
Aug 31, 2015
Add ActiveRecord-backed fixtures.
Eric-Guo
added a commit
to Eric-Guo/active_model_serializers
that referenced
this pull request
Sep 7, 2015
Eric-Guo
added a commit
to Eric-Guo/active_model_serializers
that referenced
this pull request
Sep 7, 2015
Eric-Guo
added a commit
to Eric-Guo/active_model_serializers
that referenced
this pull request
Sep 7, 2015
Eric-Guo
added a commit
to Eric-Guo/active_model_serializers
that referenced
this pull request
Sep 7, 2015
Eric-Guo
added a commit
to Eric-Guo/active_model_serializers
that referenced
this pull request
Sep 7, 2015
joaomdmoura
added a commit
that referenced
this pull request
Sep 7, 2015
… pass, which caused by #1105"
NullVoxPopuli
pushed a commit
to NullVoxPopuli/active_model_serializers
that referenced
this pull request
Sep 7, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are namespaced inside
ARModelsto avoid conficts with PORO models (that we might want to namespace as well).