Merge pull request #1692 from beauby/fix-jsonapi-tests

Fix tests to comply with the JSON API spec.
rails-api · Apr 21, 2016 · f0fa743 · f0fa743
2 parents 7485c84 + ebda34b
commit f0fa743
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/test/adapter/json_api/has_many_test.rb b/test/adapter/json_api/has_many_test.rb
@@ -131,8 +131,9 @@ def test_has_many_with_virtual_value
               id: '1',
               type: 'virtual-values',
               relationships: {
-                maker: { data: { id: 1 } },
-                reviews: { data: [{ id: 1 }, { id: 2 }] }
+                maker: { data: { type: 'makers', id: '1' } },
+                reviews: { data: [{ type: 'reviews', id: '1' },
+                                  { type: 'reviews', id: '2' }] }
               }
             }
           }, adapter.serializable_hash)

diff --git a/test/adapter/json_api/has_one_test.rb b/test/adapter/json_api/has_one_test.rb
@@ -65,8 +65,9 @@ def test_has_one_with_virtual_value
               id: '1',
               type: 'virtual-values',
               relationships: {
-                maker: { data: { id: 1 } },
-                reviews: { data: [{ id: 1 }, { id: 2 }] }
+                maker: { data: { type: 'makers', id: '1' } },
+                reviews: { data: [{ type: 'reviews', id: '1' },
+                                  { type: 'reviews', id: '2' }] }
               }
             }
           }

diff --git a/test/fixtures/poro.rb b/test/fixtures/poro.rb
@@ -227,8 +227,9 @@ def json_key
 VirtualValueSerializer = Class.new(ActiveModel::Serializer) do
   attributes :id
 
-  has_many :reviews, virtual_value: [{ id: 1 }, { id: 2 }]
-  has_one :maker, virtual_value: { id: 1 }
+  has_many :reviews, virtual_value: [{ type: 'reviews', id: '1' },
+                                     { type: 'reviews', id: '2' }]
+  has_one :maker, virtual_value: { type: 'makers', id: '1' }
 
   def reviews
   end