Skip to content

Commit

Permalink
Merge pull request #2093 from bf4/undef_unneeded_kernel_methods
Browse files Browse the repository at this point in the history
Undef problematic Object methods
  • Loading branch information
bf4 authored Apr 30, 2017
2 parents 7d0f4e0 + 4fb635b commit 81a13c4
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
3 changes: 3 additions & 0 deletions lib/active_model/serializer.rb
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@
# reified when subclassed to decorate a resource.
module ActiveModel
class Serializer
undef_method :select, :display # These IO methods, which are mixed into Kernel,
# sometimes conflict with attribute names. We don't need these IO methods.

# @see #serializable_hash for more details on these valid keys.
SERIALIZABLE_HASH_VALID_KEYS = [:only, :except, :methods, :include, :root].freeze
extend ActiveSupport::Autoload
Expand Down
1 change: 1 addition & 0 deletions lib/active_model_serializers/model.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# ActiveModelSerializers::Model is a convenient superclass for making your models
# from Plain-Old Ruby Objects (PORO). It also serves as a reference implementation
# that satisfies ActiveModel::Serializer::Lint::Tests.
require 'active_support/core_ext/hash'
module ActiveModelSerializers
class Model
include ActiveModel::Serializers::JSON
Expand Down

0 comments on commit 81a13c4

Please sign in to comment.