Fix CI build and bump version 1.2.0 → 1.2.1 #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #625 +/- ##
=======================================
Coverage 95.94% 95.94%
=======================================
Files 91 91
Lines 2390 2390
Branches 319 319
=======================================
Hits 2293 2293
Misses 55 55
Partials 42 42
Continue to review full report at Codecov.
|
karlb
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build of v1.2.0 was failing in the CI because the build process required to have yarn installed. When I changed the project to use yarn instead of npm I made this check required in the
setup.py. Before it was just skipping the webui compilation if npm was not installed. The compilation is done in a previous job in the CI so it is not needed. The build package job does not have yarn installed because it is using the python image. This PR makes the compilation in the build process optional again. I also bumped the version to quickly make a new release. The changes in thesetup.pywere tested on the failed CI job via ssh.