-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
send encrypted secret #7196
send encrypted secret #7196
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general, good job!
Once you have implemented the encryption with the correct public key we are good to go.
2 things to take care/notice:
- Somewhere deep in my memory I remember that it was not allowed to use an empty (b'0') bytestring as the secret. We should ask some Raiden OGs in the stand up.
- Some tests that encryption/decryption works would be good.
d11e81b
to
bcf1c55
Compare
89b499a
to
82ab477
Compare
619deb1
to
d5e5de0
Compare
@netcriptus nitpick: it would be nice to squash some of the changes (e.g. the pdb stuff, hex encode fix) here and split some others |
Will most definitely do it, but sadly I'm not done with this yet. I'm working on more tests. I can promise the squash will come later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some things that need to be addressed.
Also we have to sync with the tsRaiden team again - (the PR could still be merged first)
682dbbe
to
b1aba04
Compare
6454805
to
5bcc4fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I discovered a flaw in the serialize-missing
mechanism. I'd still rather fix the underlying issue, but possibly we can do that at a later time and merge the PR?
Still, let's discuss briefly in private before merging
5bcc4fa
to
2d13a7f
Compare
2d13a7f
to
0098ff9
Compare
Allow encrypted secret to be sent on LockedTransfer's metadata
Fixes: #7191