Fix oversight in style guide on Solidity #1380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czepluch
reviewed
Apr 24, 2018
CONTRIBUTING.md
Outdated
| @@ -384,7 +384,7 @@ function iDoSomething(uint awesome_argument) { | |||
| **Modifiers in long function declarations** | |||
There was a problem hiding this comment.
Maybe just remove this part altogether, since we say above that we use the solidity style guide by default.
There was a problem hiding this comment.
nah it's good to be explicit
There was a problem hiding this comment.
Then please remove with a few exceptions since this is not an exception. I would rather not be picky here, but it just doesn't make sense to me to leave any comments about this in our style guide, if we're just following the solidity style guide anyway.
There was a problem hiding this comment.
Hmm yeah you are correct, not picky. I reread it again and it should just go. It's done.
LefterisJP
force-pushed
the
style_guide_fix
branch
from
25ae688 to
f837f7f
Compare
hackaugusto
approved these changes
Apr 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.