Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont prune route on mediation #7090

Closed
fredo opened this issue May 27, 2021 · 3 comments · Fixed by #7162
Closed

Dont prune route on mediation #7090

fredo opened this issue May 27, 2021 · 3 comments · Fixed by #7162
Assignees
@ezdac
Labels
Component / Transport Transport related issues State / In discussion

Comments

@fredo
Copy link
Contributor

fredo commented May 27, 2021

In the discussion of #7021, it must be discussed whether we should manipulate expected route metadata such as the route itself.
If we decide to passthrough all metadata, routes should be kept as is and a node should be able to find himself in the route to find the next hop.

Currently the PC expects to be the first one in the list upon mediation.
@ulope
Copy link
Collaborator

ulope commented May 27, 2021

This also has privacy implications, IIRC that was the main reason we implemented route pruning in the first place.

@ezdac ezdac mentioned this issue Jun 1, 2021
Closed
@ezdac
Copy link
Contributor

ezdac commented Jun 10, 2021

The hard requirement for LC-compatibility here is that we don't rely on pruned routes for mediation (index-based access for finding the next_hop).

Note: I'm already working on this

So if we think not pruning is problematic we could still prune. More opinions on that? The LC plans to not prune at all.

@ezdac
Copy link
Contributor

ezdac commented Jun 23, 2021

We decided to not do the pruning anymore and behave the same way the LC does.
This will be implemented as part of #7162

@ezdac ezdac self-assigned this Jun 23, 2021
ezdac added a commit to ezdac/raiden that referenced this issue Jun 23, 2021
@ezdac
Remove route-pruning for mediators
934f65b 
Before this commit, a mediator would modify the routes in the metadata
to prune the graph of paths before passing the metadata to the next hop
as part of the mediated locked-transfer.

Now, the route in the metadata is solely determined by the
initiator of a payment and passed on as is by all mediators.

Fixes: raiden-network#7090
ezdac added a commit to ezdac/raiden that referenced this issue Jun 23, 2021
@ezdac
Remove route-pruning for mediators
8173cf5 
Before this commit, a mediator would modify the routes in the metadata
to prune the graph of paths before passing the metadata to the next hop
as part of the mediated locked-transfer.

Now, the route in the metadata is solely determined by the
initiator of a payment and passed on as is by all mediators.

Fixes: raiden-network#7090
@ezdac ezdac mentioned this issue Jun 24, 2021
Merged
ezdac added a commit that referenced this issue Jul 1, 2021
@ezdac
Remove route-pruning for mediators
13417e5 
Before this commit, a mediator would modify the routes in the metadata
to prune the graph of paths before passing the metadata to the next hop
as part of the mediated locked-transfer.

Now, the route in the metadata is solely determined by the
initiator of a payment and passed on as is by all mediators.

Fixes: #7090
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ezdac ezdac

Labels
Component / Transport Transport related issues State / In discussion
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Read-only Metadata forwarding and hashing scheme ezdac/raiden
3 participants
@ulope @fredo @ezdac