Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployed 0.4.0 on Goerli #863

Merged
merged 1 commit into from
Apr 15, 2019
Merged

Conversation

pirapira
Copy link
Contributor

In raiden-network/raiden#3808 we found that the Raiden client expects the 0.4.0 deployment on the Goerli chain. This commit adds that deployment.

Copy link
Contributor

@czepluch czepluch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Also checked that all addresses have code deployed on goerli.

Will you verify them at some point too?

@pirapira
Copy link
Contributor Author

@czepluch ah, I forgot etherscan. Doing now. Thanks.

@pirapira
Copy link
Contributor Author

Now I see etherscan_verify.py doesn't work with older versions. #864

@codecov
Copy link

codecov bot commented Apr 15, 2019

Codecov Report

Merging #863 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #863   +/-   ##
=======================================
  Coverage   82.87%   82.87%           
=======================================
  Files          20       20           
  Lines        1244     1244           
  Branches      136      136           
=======================================
  Hits         1031     1031           
  Misses        181      181           
  Partials       32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67645f2...e8f8ee2. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 15, 2019

Codecov Report

Merging #863 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #863   +/-   ##
=======================================
  Coverage   82.87%   82.87%           
=======================================
  Files          20       20           
  Lines        1244     1244           
  Branches      136      136           
=======================================
  Hits         1031     1031           
  Misses        181      181           
  Partials       32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67645f2...e8f8ee2. Read the comment docs.

@pirapira pirapira merged commit 7703e26 into raiden-network:master Apr 15, 2019
@pirapira pirapira deleted the goerli_0_4_0 branch April 15, 2019 14:54
@pirapira
Copy link
Contributor Author

This was a first step for raiden-network/raiden#3819.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants