Don't try to find service contracts for RedEyes

raiden_contracts/contract_manager.py

@@ -3,6 +3,7 @@
 from copy import deepcopy
 from json import JSONDecodeError
 from pathlib import Path
+from semver import compare
 from typing import Any, Dict, List, Optional
 
 from deprecated import deprecated
@@ -164,6 +165,16 @@ def merge_deployment_data(dict1: Dict, dict2: Dict) -> Dict:
     return result
 
 
+def version_provides_services(version: Optional[str]) -> bool:
+    if version is None:
+        return True
+    if version == '0.3._':
+        return False
+    if version == '0.8.0_unlimited':
+        return True
+    return compare(version, '0.8.0') >= 0
+
+
 def get_contracts_deployment_info(
         chain_id: int,
         version: Optional[str] = None,
@@ -172,21 +183,31 @@ def get_contracts_deployment_info(
     """Reads the deployment data.
 
     Parameter:
-        module The name of the module. ALL means deployed contracts from all modules.
+        module The name of the module. ALL means deployed contracts from all modules that are
+        available for the version.
     """
     if module not in DeploymentModule:
         raise ValueError(f'Unknown module {module} given to get_contracts_deployment_info()')
 
+    def module_chosen(to_be_added: DeploymentModule):
+        return module == to_be_added or module == DeploymentModule.ALL
+
     files: List[Path] = []
 
-    if module == DeploymentModule.RAIDEN or module == DeploymentModule.ALL:
+    if module_chosen(DeploymentModule.RAIDEN):
         files.append(contracts_deployed_path(
             chain_id=chain_id,
             version=version,
             services=False,
         ))
 
-    if module == DeploymentModule.SERVICES or module == DeploymentModule.ALL:
+    if module == DeploymentModule.SERVICES and not version_provides_services(version):
+        raise ValueError(
+            f'SERVICES module queried for version {version}, but {version} '
+            'does not provide service contracts.',
+        )
+
+    if module_chosen(DeploymentModule.SERVICES) and version_provides_services(version):
         files.append(contracts_deployed_path(
             chain_id=chain_id,
             version=version,

raiden_contracts/tests/test_deploy_data.py

@@ -9,6 +9,7 @@
     get_contracts_deployed,
     get_contracts_deployment_info,
     merge_deployment_data,
+    version_provides_services,
 )
 
 
@@ -112,3 +113,27 @@ def test_deploy_data_all(
 def test_deploy_data_unknown_module():
     with pytest.raises(ValueError):
         get_contracts_deployment_info(3, None, module=None)  # type: ignore
+
+
+@pytest.mark.parametrize('chain_id', [3, 4, 42])
+def test_deploy_data_for_redeyes_succeed(chain_id):
+    """ get_contracts_deployment_info() on RedEyes version should return a non-empty dictionary """
+    assert get_contracts_deployment_info(chain_id, '0.4.0')
+
+
+@pytest.mark.parametrize('chain_id', [3, 4, 42])
+def test_service_deploy_data_for_redeyes_fail(chain_id):
+    """ get_contracts_deployment_info() on RedEyes version should return a non-empty dictionary """
+    with pytest.raises(ValueError):
+        assert get_contracts_deployment_info(chain_id, '0.4.0', DeploymentModule.SERVICES)
+
+
+def test_version_provides_services():
+    assert not version_provides_services('0.3._')
+    assert not version_provides_services('0.4.0')
+    assert version_provides_services('0.8.0')
+    assert version_provides_services('0.8.0_unlimited')
+    assert version_provides_services('0.10.1')
+    assert version_provides_services('0.11.0')
+    with pytest.raises(ValueError):
+        assert version_provides_services('not a semver')