-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Earlier Monitoring Rewards #749
Conversation
Codecov Report
@@ Coverage Diff @@
## master #749 +/- ##
=======================================
Coverage 81.47% 81.47%
=======================================
Files 18 18
Lines 1139 1139
Branches 113 113
=======================================
Hits 928 928
Misses 183 183
Partials 28 28 Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #749 +/- ##
=======================================
Coverage 81.47% 81.47%
=======================================
Files 18 18
Lines 1139 1139
Branches 113 113
=======================================
Hits 928 928
Misses 183 183
Partials 28 28 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Contract changes look good to me and we added a test to make sure it works as expected.
The only strange thing is that I only see one checkmark in the test run (https://travis-ci.org/raiden-network/raiden-contracts/builds/508306124#L446), but maybe this is just scaling:
raiden_contracts/tests/test_monitoring_service.py ✓
The test output is messy since I introduced codecov (I changed |
After this PR, monitoring services can claim rewards as soon as the settlement period finishes. Before this PR, they had to wait until all locked amounts are claimed.
See #744 and #747 for how this change came about.