Make deposit limits configurable at TokenNetowk #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirapira
force-pushed
the
configure-limits
branch
from
9d5b0f2 to
e300a3e
Compare
deployment time. After some trial and error I believe that the best approach to accomodate the different use cases of TokenNetwork is to make it configurable at the deployment time, as opposed to providing multiple flavors or versions of the source code.
pirapira
force-pushed
the
configure-limits
branch
from
e300a3e to
5f443f2
Compare
|
I'm breaking rules because this portion is now at the bottleneck. |
pirapira
added a commit
to pirapira/spec
that referenced
this pull request
Sep 5, 2019
This follows the change in the implementation raiden-network/raiden-contracts#655 This commit is a part of updating the specification: raiden-network#253
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deployment time.
After some trial and error, I believe that the best approach to accommodate the different use cases of TokenNetwork is to make it configurable at the deployment time, as opposed to providing multiple flavors or versions of the source code.