Script for verifying contracts with etherscan #345
Conversation
Rough script to verify contracts. To be used like: ``` python -m raiden_contracts.deploy.etherscan_verify --apikey ETHERSCAN_APIKEY --contract-name EndpointRegistry --chain-id 3 python -m raiden_contracts.deploy.etherscan_verify --apikey ETHERSCAN_APIKEY --contract-name SecretRegistry --chain-id 3 python -m raiden_contracts.deploy.etherscan_verify --apikey ETHERSCAN_APIKEY --contract-name TokenNetworkRegistry --chain-id 3 ```
| source_path['raiden'].joinpath('SecretRegistry.sol').read_text() + | ||
| source_path['raiden'].joinpath('TokenNetwork.sol').read_text() + | ||
| source_path['raiden'].joinpath('TokenNetworkRegistry.sol').read_text() | ||
| ) |
There was a problem hiding this comment.
Ideally, the flattening should not be done like this, but following the compiled AST imports order or using a dedicated flattening package (I have not found one that works).
Can be improved in a future PR. For now, it does the job.
| elif chain_id == 42: | ||
| etherscan_api = 'https://api-kovan.etherscan.io/api' | ||
| elif chain_id == 1: | ||
| etherscan_api = 'https://api.etherscan.io/api' |
There was a problem hiding this comment.
Style nitpick:
I think for this we can use a dictionary where:
{
3: "'https://api-ropsten.etherscan.io/api'",
4: "https://api-rinkeby.etherscan.io/api",
... etc
}
And use .get(chain_id) to fetch the URL that needs to be called.
| if contract_name is None or contract_name == CONTRACT_SECRET_REGISTRY: | ||
| path = source_path['raiden'].joinpath(f'{CONTRACT_SECRET_REGISTRY}.sol') | ||
| source = path.read_text() | ||
| constructor_args = '' |
There was a problem hiding this comment.
Can this be refactored somehow into it's own function? as this block uses the same code as the block above it.
| source = source.replace('import "raiden/TokenNetwork.sol";\n', '') | ||
|
|
||
| flatten_path = Path(__file__).parent.joinpath('flatten.sol') | ||
| flatten_path.open('w').write(source) |
| )[0]['inputs'] | ||
| ] | ||
| constructor_args = encode_abi(constructor_types, constructor_arguments).hex() | ||
| print('constructor_args', constructor_arguments, constructor_types, constructor_args) |
There was a problem hiding this comment.
Actually I wanted the constructor_args shown because automatic verification failed for some reason for TokenNetworkRegistry and you need to paste these manually in Etherscan.
True, pprint or using logging would be better.
| 'runs': metadata['settings']['optimizer']['runs'], | ||
| 'constructorArguments': constructor_args, | ||
| } | ||
| print({k: v for k, v in data.items() if k is not 'sourceCode'}) |
There was a problem hiding this comment.
Might be a good idea to use pprint to have the data printed a bit more readable?
|
@rakanalh valid review points, thank you. Can we merge this as is and link your suggestions in an issue, to be fixed later? (you can also pick this up if you want) I did not want to spend more time on this script for now. |
|
Thank you. Documented the improvements here: #349, so anyone can pick it up when they have time. |
fixes #319
Rough script to verify contracts. To be used like:
Etherscan verification works for
EndpointRegistryandSecretRegistry.For some reason, the verification fails for
TokenNetworkRegistry. However, if you manually verify on Etherscan using theflatten.solsource created by the script inraiden_contracts/deploy/and the data printed by the script (solcversion, ABI encoded constructor arguments etc.), then it works!Could be improved, but I would merge it as it is now and improve it in another PR