List addresses that have ever made deposits #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
all registered services can be somehow discovered.
Codecov Report
@@ Coverage Diff @@
## master #1140 +/- ##
=======================================
Coverage 81.18% 81.18%
=======================================
Files 21 21
Lines 1446 1446
Branches 188 188
=======================================
Hits 1174 1174
Misses 230 230
Partials 42 42Continue to review full report at Codecov.
|
karlb
approved these changes
Jul 26, 2019
| require(now < service_valid_till[msg.sender], "registration expired"); | ||
| require(bytes(new_url).length != 0, "new url is empty string"); | ||
| urls[msg.sender] = new_url; | ||
| return true; | ||
| } | ||
|
|
||
| /// A getter function for seeing the length of ever_made_deposits array. | ||
| function ever_made_deposits_len() public view returns (uint256 _len) { |
There was a problem hiding this comment.
It's really weird that solidity does not provide this for public arrays itself.
There was a problem hiding this comment.
I agree. It's weird.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was integrating
raiden-contrtacts 0.26.0with the Raiden client, I realized that there must be a way for the client to look up all registered services in ServiceRegistry contract. This PR provides a poor man's solution to this problem, namely, a list of all addresses that have ever made a deposit. The client can then query about any address in the list.This closes #1139.