OneToN.claim() considers MessageTypeId.IOU #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirapira
force-pushed
the
claim-message-id
branch
from
faa11e5 to
3527572
Compare
Codecov Report
@@ Coverage Diff @@
## master #1024 +/- ##
==========================================
+ Coverage 85.14% 85.15% +0.01%
==========================================
Files 20 20
Lines 1373 1374 +1
Branches 182 182
==========================================
+ Hits 1169 1170 +1
Misses 158 158
Partials 46 46
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1024 +/- ##
==========================================
+ Coverage 88.58% 88.59% +<.01%
==========================================
Files 19 19
Lines 1323 1324 +1
Branches 178 178
==========================================
+ Hits 1172 1173 +1
Misses 106 106
Partials 45 45
Continue to review full report at Codecov.
|
pirapira
force-pushed
the
claim-message-id
branch
from
3527572 to
e792112
Compare
This prevents confusion between different types of messages.
pirapira
force-pushed
the
claim-message-id
branch
from
e792112 to
c2a6bfe
Compare
karlb
approved these changes
Jun 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents confusion between different types of messages.
This closes #1020.