Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if setTotalWithdraw has a redundant partner argument. #238

Closed
loredanacirstea opened this issue Aug 15, 2018 · 0 comments
Closed

Check if setTotalWithdraw has a redundant partner argument. #238

loredanacirstea opened this issue Aug 15, 2018 · 0 comments
Assignees
Milestone

Comments

@loredanacirstea
Copy link
Contributor

function setTotalWithdraw(
uint256 channel_identifier,
address participant,
uint256 total_withdraw,
address partner,
bytes participant_signature,
bytes partner_signature
)

As @hackaugusto pointed out, partner can be computed from partner_signature.

Then the channel_identifier checks can be done after the address recovery (e.g. the require(channel_identifier == getChannelIdentifier(participant, partner));)
So, at this point it does seem redundant.

@loredanacirstea loredanacirstea added this to the Red Eyes milestone Aug 20, 2018
@err508 err508 self-assigned this Aug 22, 2018
err508 added a commit to err508/raiden-contracts that referenced this issue Aug 22, 2018
 as described in  raiden-network#238. Additionally, the function was refactored
to be more clear and readable, as discussed in raiden-network#47.
err508 added a commit to err508/raiden-contracts that referenced this issue Aug 22, 2018
 as described in  raiden-network#238. Additionally, the function was refactored
to be more clear and readable, as discussed in raiden-network#47.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants