Contract Updates #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apbendi
approved these changes
Nov 18, 2020
|
Before merging this, I'm going to deploy the final mainnet and Rinkeby versions. But I'm going to wait a few days to do that final deploy, because:
Because Etherscan verification is a pain, and we still need to finish a few other tasks before launch, I think it's ok to wait a few days until that's fixed before deploying the final contracts |
cupOJoseph
approved these changes
Nov 23, 2020
Removed the immutable keyword from the Factory contract, because Etherscan would not verify the contract when present. Since the only benefit of that keyword is slightly reduced gas costs when creating a token, it was easiest to just remove that keyword
|
Mainnet and rinkeby contracts deployed and verified on Etherscan. Both are at 0x358bcf43fe7ec2659aD829F3604c72781fc93a9E |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes:
Other changes:
MintedandBurnedeventsYou can see the factory contract deployed and verified on Rinkeby here: (https://rinkeby.etherscan.io/address/0x4FB8Ad81754a5330165277a2655d47e99A7F598E)