-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace eager_replace!
with preinterpret!
#2067
Conversation
Docker tags |
Docker tags |
eager_replace!
with preinterpret!
Benchmark for 5d8aa05Click to view benchmark
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Read up your README.md
for the crate and it's very well written and honestly explains everything about this crate and macro very well.
Summary
eager_replace!
macro withpreinterpret!
- which I've rewritten from scratch and open sourced at https://github.com/dhedey/preinterpret (roughly it's a next-generationpaste!
)In future, we could replace all instances of
paste!
with preinterpret too, which would simplify quite a few macros.Testing
Existing tests pass.
Changelog
Updated