Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak: Change dependency version fixing #2054

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

dhedey
Copy link
Contributor

@dhedey dhedey commented Jan 14, 2025

Summary

Following discussions with the wallet team integrating into sargon, who had some issues with the regex version being fixed, I'm just pulling together a PR to unfix this version, in the hopes that it makes it easier to integrate as a library.

The node still uses a fixed version courtesy of the lock file of course.

Testing

Existing tests pass

Changelog

N/A

@dhedey dhedey requested a review from a team as a code owner January 14, 2025 12:18
Copy link

github-actions bot commented Jan 14, 2025

Docker tags
docker.io/radixdlt/private-scrypto-builder:e6336c6a96

Copy link

github-actions bot commented Jan 14, 2025

Docker tags
docker.io/radixdlt/private-scrypto-dev-container:e6336c6a96

Copy link

Benchmark for e6336c6

Click to view benchmark
Test Base PR %
costing::bench_prepare_wasm 45.1±0.20ms 45.2±0.19ms +0.22%
costing::decode_encoded_i8_array_to_manifest_raw_value 19.4±0.03ms 19.4±0.02ms 0.00%
costing::decode_encoded_i8_array_to_manifest_value 41.6±0.09ms 42.2±0.15ms +1.44%
costing::decode_encoded_tuple_array_to_manifest_raw_value 72.4±0.08ms 72.1±0.09ms -0.41%
costing::decode_encoded_tuple_array_to_manifest_value 98.8±0.19ms 99.5±0.32ms +0.71%
costing::decode_encoded_u8_array_to_manifest_raw_value 26.0±0.08µs 31.7±0.11µs +21.92%
costing::decode_encoded_u8_array_to_manifest_value 41.7±0.10ms 42.4±0.08ms +1.68%
costing::decode_rpd_to_manifest_raw_value 14.5±0.04µs 14.5±0.04µs 0.00%
costing::decode_rpd_to_manifest_value 10.8±0.02µs 10.8±0.01µs 0.00%
costing::deserialize_wasm 1241.4±3.65µs 1222.9±2.82µs -1.49%
costing::execute_transaction_creating_big_vec_substates 701.9±3.81ms 713.5±10.38ms +1.65%
costing::execute_transaction_reading_big_vec_substates 580.7±2.07ms 604.2±1.90ms +4.05%
costing::instantiate_flash_loan 963.0±1037.12µs 905.5±295.56µs -5.97%
costing::instantiate_radiswap 908.1±665.11µs 1032.8±1400.96µs +13.73%
costing::scrypto_malloc 663.3±1.75ms 666.2±1.68ms +0.44%
costing::scrypto_sbor_decode 667.7±2.43ms 667.1±1.68ms -0.09%
costing::scrypto_sha256 597.8±0.64ms 592.6±0.93ms -0.87%
costing::spin_loop_v1 513.8±1.53ms 512.6±0.93ms -0.23%
costing::spin_loop_v2 597.9±1.07ms 596.9±2.08ms -0.17%
costing::validate_sbor_payload 29.5±0.06µs 30.1±0.06µs +2.03%
costing::validate_sbor_payload_bytes 242.2±0.81ns 245.5±0.63ns +1.36%
costing::validate_secp256k1 76.7±0.10µs 76.7±0.06µs 0.00%
costing::validate_wasm 34.2±0.03ms 33.9±0.06ms -0.88%
decimal::add/0 8.4±0.00ns 8.4±0.00ns 0.00%
decimal::add/rust-native 9.8±0.00ns 9.8±0.00ns 0.00%
decimal::add/wasmi 305.7±2.11ns 316.5±2.95ns +3.53%
decimal::add/wasmi-call-native 2.9±0.00µs 2.9±0.01µs 0.00%
decimal::div/0 168.9±0.09ns 168.6±0.13ns -0.18%
decimal::from_string/0 156.1±0.55ns 156.0±0.08ns -0.06%
decimal::mul/0 129.4±0.04ns 129.6±0.09ns +0.15%
decimal::mul/rust-native 124.8±0.07ns 125.0±0.11ns +0.16%
decimal::mul/wasmi 19.3±0.06µs 19.2±0.07µs -0.52%
decimal::mul/wasmi-call-native 3.1±0.00µs 3.1±0.01µs 0.00%
decimal::pow/0 592.5±0.14ns 592.6±0.52ns +0.02%
decimal::pow/rust-native 599.4±0.60ns 591.8±0.53ns -1.27%
decimal::pow/wasmi 90.8±0.14µs 91.4±0.29µs +0.66%
decimal::pow/wasmi-call-native 4.8±0.01µs 4.8±0.01µs 0.00%
decimal::root/0 8.3±0.01µs 8.2±0.01µs -1.20%
decimal::sub/0 8.4±0.01ns 8.4±0.01ns 0.00%
decimal::to_string/0 438.8±0.37ns 439.2±0.46ns +0.09%
large_transaction_processing::prepare 2.6±0.00ms 2.6±0.00ms 0.00%
large_transaction_processing::prepare_and_decompile 6.3±0.04ms 6.3±0.01ms 0.00%
large_transaction_processing::prepare_and_decompile_and_recompile 29.7±1.64ms 30.6±1.51ms +3.03%
metadata_validation::validate_urls 4.7±0.01µs 4.8±0.03µs +2.13%
precise_decimal::add/0 8.7±0.04ns 8.7±0.07ns 0.00%
precise_decimal::add/rust-native 10.7±0.02ns 10.6±0.01ns -0.93%
precise_decimal::add/wasmi 413.5±4.79ns 412.1±1.86ns -0.34%
precise_decimal::add/wasmi-call-native 3.8±0.01µs 3.8±0.00µs 0.00%
precise_decimal::div/0 306.5±0.67ns 306.3±1.92ns -0.07%
precise_decimal::from_string/0 206.3±0.46ns 215.4±0.28ns +4.41%
precise_decimal::mul/0 349.9±1.32ns 349.8±2.48ns -0.03%
precise_decimal::mul/rust-native 283.5±0.20ns 283.4±0.34ns -0.04%
precise_decimal::mul/wasmi 48.0±0.07µs 47.9±0.22µs -0.21%
precise_decimal::mul/wasmi-call-native 4.2±0.01µs 4.2±0.02µs 0.00%
precise_decimal::pow/0 1737.8±3.18ns 1737.5±2.08ns -0.02%
precise_decimal::pow/rust-native 1366.2±1.73ns 1353.9±1.24ns -0.90%
precise_decimal::pow/wasmi 229.5±1.01µs 230.6±0.45µs +0.48%
precise_decimal::pow/wasmi-call-native 7.5±0.02µs 7.5±0.01µs 0.00%
precise_decimal::root/0 58.1±0.05µs 58.8±0.04µs +1.20%
precise_decimal::sub/0 8.9±0.12ns 8.9±0.04ns 0.00%
precise_decimal::to_string/0 688.0±0.67ns 693.1±0.51ns +0.74%
schema::validate_payload 394.6±1.30µs 394.3±0.56µs -0.08%
transaction::radiswap 5.0±0.02ms 4.9±0.02ms -2.00%
transaction::transfer 1799.9±2.27µs 1809.1±1.83µs +0.51%
transaction_validation::validate_manifest 43.1±0.09µs 44.7±0.06µs +3.71%
transaction_validation::verify_bls_2KB 1005.2±12.95µs 1047.1±33.03µs +4.17%
transaction_validation::verify_bls_32B 1001.9±6.09µs 1039.0±31.56µs +3.70%
transaction_validation::verify_ecdsa 74.6±0.10µs 74.5±0.06µs -0.13%
transaction_validation::verify_ed25519 46.5±0.05µs 42.3±0.10µs -9.03%

Copy link

@CyonAlexRDX CyonAlexRDX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@dhedey dhedey changed the base branch from feature/add-dugong to develop January 15, 2025 15:10
@dhedey dhedey merged commit d5207a7 into develop Jan 15, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants