Adding substate and partition delete support to FlashLedgerTransaction in Core API #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re/substate_flash_core_api
jakrawcz-rdx
commented
Jan 22, 2024
| @@ -7413,10 +7413,10 @@ components: | |||
| - $ref: "#/components/schemas/LedgerTransaction" | |||
| - type: object | |||
| required: | |||
| - flash_transaction | |||
| - flashed_state_updates | |||
There was a problem hiding this comment.
(note from author)
A flash transaction, apart from state updates, also has a name.
Do we want to include it in the Core API response?
There was a problem hiding this comment.
(already done - see - name one line above)
|
Docker tags |
jakrawcz-rdx
commented
Jan 22, 2024
| @@ -1360,7 +1360,6 @@ impl SubstateDatabase for RocksDBStore { | |||
| self.open_db_context() | |||
| .cf(SubstatesCf) | |||
| .iterate_group_from(&(partition_key.clone(), from_sort_key), Direction::Forward) | |||
| .take_while(move |((next_key, _), _)| next_key == &partition_key) | |||
There was a problem hiding this comment.
(note from author)
This is just a drive-by mentioned at https://rdxworks.slack.com/archives/D04CPLNN81Y/p1705591790950219
…tes) + Asserting on flash txns' receipts.
…re/substate_flash_core_api
…re/substate_flash_core_api
|
dhedey
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An omission reported at https://rdxworks.slack.com/archives/C01M90Y2448/p1705913560366799
Intuitively, the
FlashTransactioncould be represented asStateUpdates.However, our existing
StateUpdatesCore API output is very receipt-focused (e.g. it includes previous value for substate updates) and it is hard to render forFlashTransaction. So I had to re-create a similar structure.