Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to the common dockerhub credentials #1051

Closed
wants to merge 1 commit into from
Closed

Conversation

muzuke
Copy link
Contributor

@muzuke muzuke commented Jan 9, 2025

The goal is to remove duplicated secret entries.

@muzuke muzuke requested a review from a team January 9, 2025 09:49
Copy link

github-actions bot commented Jan 9, 2025

Docker tags
docker.io/radixdlt/private-babylon-node:pr-1051
docker.io/radixdlt/private-babylon-node:5149873c50
docker.io/radixdlt/private-babylon-node:sha-5149873

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.5%. Comparing base (60c88c1) to head (642e43c).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #1051     +/-   ##
=========================================
+ Coverage     40.8%   42.5%   +1.6%     
+ Complexity    4636    4628      -8     
=========================================
  Files         1892    1782    -110     
  Lines        58117   55175   -2942     
  Branches      1550    1524     -26     
=========================================
- Hits         23751   23450    -301     
+ Misses       33878   31247   -2631     
+ Partials       488     478     -10     
Flag Coverage Δ
rust 42.5% <ø> (+1.6%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 121 files with indirect coverage changes

Copy link

sonarqubecloud bot commented Jan 9, 2025

@muzuke muzuke marked this pull request as draft January 9, 2025 11:17
@muzuke
Copy link
Contributor Author

muzuke commented Jan 10, 2025

Closing as not needed.

@muzuke muzuke closed this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants