Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TransactionPreviewResponse in Core API schema #1043

Merged
merged 5 commits into from
Jan 7, 2025

Conversation

lrubasze
Copy link
Contributor

Summary

Deprecate and mark as not-required instruction_resource_changes field in TransactionPreviewResponse.

@lrubasze lrubasze changed the title Update transaction preview schema Update TransactionPreviewResponse in Core API schema Dec 18, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.

Project coverage is 40.8%. Comparing base (a140643) to head (68c3e0a).

Files with missing lines Patch % Lines
...-api-server/src/mesh_api/conversions/operations.rs 0.0% 5 Missing ⚠️
...pi-server/src/mesh_api/handlers/account_balance.rs 0.0% 5 Missing ⚠️
...st/core-api-server/src/core_api/conversions/lts.rs 0.0% 4 Missing ⚠️
...erver/src/mesh_api/handlers/mempool_transaction.rs 0.0% 3 Missing ⚠️
...i/generated/models/transaction_preview_response.rs 0.0% 2 Missing ⚠️
...erver/src/core_api/handlers/transaction_preview.rs 0.0% 2 Missing ⚠️
...-api-server/src/mesh_api/conversions/addressing.rs 0.0% 1 Missing ⚠️
core-rust/mesh-api-server/src/mesh_api/errors.rs 0.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             develop   #1043     +/-   ##
===========================================
- Coverage       40.8%   40.8%   -0.1%     
+ Complexity      4630    4627      -3     
===========================================
  Files           1892    1892             
  Lines          57699   57699             
  Branches        1527    1527             
===========================================
- Hits           23576   23571      -5     
- Misses         33644   33648      +4     
- Partials         479     480      +1     
Flag Coverage Δ
rust 40.8% <0.0%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...-api-server/src/mesh_api/conversions/addressing.rs 13.1% <0.0%> (ø)
core-rust/mesh-api-server/src/mesh_api/errors.rs 0.0% <0.0%> (ø)
...i/generated/models/transaction_preview_response.rs 0.0% <0.0%> (ø)
...erver/src/core_api/handlers/transaction_preview.rs 0.0% <0.0%> (ø)
...erver/src/mesh_api/handlers/mempool_transaction.rs 0.0% <0.0%> (ø)
...st/core-api-server/src/core_api/conversions/lts.rs 0.0% <0.0%> (ø)
...-api-server/src/mesh_api/conversions/operations.rs 0.0% <0.0%> (ø)
...pi-server/src/mesh_api/handlers/account_balance.rs 0.0% <0.0%> (ø)

... and 3 files with indirect coverage changes

Copy link

github-actions bot commented Dec 18, 2024

Docker tags
docker.io/radixdlt/private-babylon-node:pr-1043
docker.io/radixdlt/private-babylon-node:0ebeb59e50
docker.io/radixdlt/private-babylon-node:sha-0ebeb59

Copy link
Contributor

@dhedey dhedey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks

@radixbot
Copy link
Contributor

Benchmark summary 2024-12-23 10:26:26

Test case: xrd_transfer, TPS: 170
Test case: basic_swap, TPS: 135
Test case: radquest, TPS: 78

Benchmark dashboard
Node dashboard
Node JVM dashboard
Node Logs

@radixbot
Copy link
Contributor

radixbot commented Jan 6, 2025

Benchmark summary 2025-01-06 15:41:58

Test case: xrd_transfer, TPS: 177
Test case: basic_swap, TPS: 143
Test case: radquest, TPS: 78

Benchmark dashboard
Node dashboard
Node JVM dashboard
Node Logs

@radixbot
Copy link
Contributor

radixbot commented Jan 6, 2025

Benchmark summary 2025-01-06 17:25:27

Test case: xrd_transfer, TPS: 171
Test case: basic_swap, TPS: 143
Test case: radquest, TPS: 78

Benchmark dashboard
Node dashboard
Node JVM dashboard
Node Logs

Copy link

sonarqubecloud bot commented Jan 7, 2025

@radixbot
Copy link
Contributor

radixbot commented Jan 7, 2025

Benchmark summary 2025-01-07 07:37:47

Test case: xrd_transfer, TPS: 172
Test case: basic_swap, TPS: 138
Test case: radquest, TPS: 75

Benchmark dashboard
Node dashboard
Node JVM dashboard
Node Logs

@iamyulong iamyulong merged commit 1021be8 into develop Jan 7, 2025
25 checks passed
@iamyulong iamyulong deleted the update/transaction-preview-schema branch January 7, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants