-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating doc to use DE from existing installation #7964
base: main
Are you sure you want to change the base?
Conversation
.vscode/launch.json
Outdated
"KUBERNETESBICEPEXTENSIBILITYURL": "http://localhost:5017/api", | ||
"RADIUSBACKENDURI": "http://localhost:9000", | ||
}, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we leave this here? It's still useful.
That gives users the choice of either:
- Using the DE from a cluster
- Using the DE from local source code
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7964 +/- ##
==========================================
- Coverage 59.94% 59.87% -0.07%
==========================================
Files 596 596
Lines 40432 40512 +80
==========================================
+ Hits 24238 24258 +20
- Misses 14367 14425 +58
- Partials 1827 1829 +2 ☔ View full report in Codecov by Sentry. |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating this @nithyatsu. Were you able validate that this setup works?
...ntributing/contributing-code/contributing-code-control-plane/running-controlplane-locally.md
Outdated
Show resolved
Hide resolved
...ntributing/contributing-code/contributing-code-control-plane/running-controlplane-locally.md
Outdated
Show resolved
Hide resolved
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
...ntributing/contributing-code/contributing-code-control-plane/running-controlplane-locally.md
Outdated
Show resolved
Hide resolved
...ntributing/contributing-code/contributing-code-control-plane/running-controlplane-locally.md
Show resolved
Hide resolved
...ntributing/contributing-code/contributing-code-control-plane/running-controlplane-locally.md
Show resolved
Hide resolved
...ntributing/contributing-code/contributing-code-control-plane/running-controlplane-locally.md
Show resolved
Hide resolved
...ntributing/contributing-code/contributing-code-control-plane/running-controlplane-locally.md
Outdated
Show resolved
Hide resolved
...ntributing/contributing-code/contributing-code-control-plane/running-controlplane-locally.md
Outdated
Show resolved
Hide resolved
5d466a5
to
d2bdfcb
Compare
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Description
deployment-engine is currently a private repo. Updating contributor docs to use DE from existing installation.
Type of change