Update validate workflow to test against PR specific schema changes #7814

sk593 · 2024-08-15T20:17:46Z

Description

Please explain the changes you've made.

Type of change

This pull request fixes a bug in Radius and has an approved issue (issue link required).
This pull request adds or changes features of Radius and has an approved issue (issue link required).
This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #issue_number

github-actions · 2024-08-15T20:41:34Z

Unit Tests

3 299 tests ±0 3 293 ✅ ±0 3m 55s ⏱️ +5s
263 suites ±0 6 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit f645354. ± Comparison against base commit 875c5ca.

♻️ This comment has been updated with latest results.

codecov · 2024-08-15T20:50:36Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.05%. Comparing base (875c5ca) to head (f645354).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7814      +/-   ##
==========================================
- Coverage   61.06%   61.05%   -0.02%     
==========================================
  Files         523      523              
  Lines       27466    27466              
==========================================
- Hits        16772    16768       -4     
- Misses       9210     9212       +2     
- Partials     1484     1486       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: sk593 <[email protected]>

radius-functional-tests · 2024-08-20T17:25:32Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	radius-project/radius
Commit ref	`1284bd9`
Unique ID	funce9118d8ecc
Image tag	pr-funce9118d8ecc

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funce9118d8ecc
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funce9118d8ecc
controller test image location: ghcr.io/radius-project/dev/controller:pr-funce9118d8ecc
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funce9118d8ecc
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting datastoresrp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ datastoresrp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

superbeeny · 2024-08-20T20:00:04Z

This PR helps me resolve some of the functional testing issues within #7744

rynowak · 2024-08-20T20:08:36Z

.github/workflows/validate-bicep.yaml

+          registry-port: ${{ env.LOCAL_REGISTRY_PORT }}
+      - name: Publish bicep types 
+        run: | 
+          bicep publish-extension ./hack/bicep-types-radius/generated/index.json --target br:${{ env.LOCAL_REGISTRY_SERVER }}:${{ env.LOCAL_REGISTRY_PORT }}/radius:latest --force  


Do we need the registry? It is possible to place the extension on disk?

We need a registry but it doesn't have to be a locally hosted one. The action to create one already exists in the repo (and this is how we do it in other workflows) so it made sense to use that

Ok cool 👍

For some reason I thought we had the ability to reference an extension as a file from bicepconfig.json. If that were possible, it would be fewer moving pieces.

rynowak · 2024-08-20T20:08:49Z

test/testrecipes/test-bicep-recipes/dapr-pubsub-broker.bicep

@@ -14,6 +14,7 @@ module redis '../../../test/testrecipes/modules/redis-selfhost.bicep' = {
  }
 }

+#disable-next-line BCP081


What's this one?

Resource type "dapr.io/Component@v1alpha1" does not have types available. Bicep is unable to validate resource properties prior to deployment, but this will not block the resource from being deployed.bicep(BCP081)

There's no linter rule alias for this so I used the number instead

rynowak · 2024-08-20T20:09:29Z

test/testrecipes/test-bicep-recipes/mongodb-recipe-context.bicep

@@ -44,7 +44,9 @@ output result object = {
    username: account.name
  }
  secrets: {
+    #disable-next-line outputs-should-not-contain-secrets


sk593 · 2024-08-20T20:27:24Z

This PR helps me resolve some of the functional testing issues within #7744

Hi @superbeeny! The validate bicep workflow is independent from the functional tests runs so there shouldn't be overlap between the type artifacts. The functional tests should already test against PR-specific schema changes. Are you seeing issues with the functional tests not picking up schema changes?

radius-functional-tests · 2024-08-21T18:25:37Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	radius-project/radius
Commit ref	`f645354`
Unique ID	funcf49accc848
Image tag	pr-funcf49accc848

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcf49accc848
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcf49accc848
controller test image location: ghcr.io/radius-project/dev/controller:pr-funcf49accc848
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcf49accc848
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting datastoresrp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ datastoresrp-cloud functional tests succeeded
❌ corerp-cloud functional test failed. Please check the logs for more details
✅ ucp-cloud functional tests succeeded
⌛ Starting corerp-cloud functional tests...
✅ corerp-cloud functional tests succeeded

ytimocin · 2024-08-21T21:03:59Z

.github/workflows/validate-bicep.yaml

+      - name: Create a secure local registry
+        id: create-local-registry
+        uses: ./.github/actions/create-local-registry
+        with:
+          secure: "true"
+          registry-name: ${{ env.LOCAL_REGISTRY_NAME }}
+          registry-server: ${{ env.LOCAL_REGISTRY_SERVER }}
+          registry-port: ${{ env.LOCAL_REGISTRY_PORT }}


The power of custom actions 💪

…adius-project#7814) # Description _Please explain the changes you've made._ ## Type of change  - This pull request fixes a bug in Radius and has an approved issue (issue link required). - This pull request adds or changes features of Radius and has an approved issue (issue link required). - This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).  Fixes: #issue_number --------- Signed-off-by: sk593 <[email protected]> Signed-off-by: Reshma Abdul Rahim <[email protected]>

sk593 had a problem deploying to functional-tests August 15, 2024 20:17 — with GitHub Actions Failure

sk593 force-pushed the update-validate-bicep-workflow branch from 8b1c8a9 to 18fa65b Compare August 15, 2024 20:20

sk593 had a problem deploying to functional-tests August 15, 2024 20:20 — with GitHub Actions Failure

sk593 had a problem deploying to functional-tests August 15, 2024 20:25 — with GitHub Actions Failure

sk593 force-pushed the update-validate-bicep-workflow branch from 7582594 to dcd6cd6 Compare August 15, 2024 20:30

sk593 had a problem deploying to functional-tests August 15, 2024 20:30 — with GitHub Actions Failure

sk593 force-pushed the update-validate-bicep-workflow branch from dcd6cd6 to 7d2fe4a Compare August 15, 2024 20:32

sk593 had a problem deploying to functional-tests August 15, 2024 20:32 — with GitHub Actions Failure

sk593 had a problem deploying to functional-tests August 15, 2024 23:37 — with GitHub Actions Failure

sk593 force-pushed the update-validate-bicep-workflow branch from ebe17a1 to bf007b3 Compare August 15, 2024 23:38

sk593 had a problem deploying to functional-tests August 15, 2024 23:38 — with GitHub Actions Failure

sk593 force-pushed the update-validate-bicep-workflow branch from bf007b3 to 6b46ec5 Compare August 15, 2024 23:44

sk593 had a problem deploying to functional-tests August 15, 2024 23:44 — with GitHub Actions Failure

sk593 force-pushed the update-validate-bicep-workflow branch from 6b46ec5 to 07815dc Compare August 15, 2024 23:51

sk593 had a problem deploying to functional-tests August 15, 2024 23:51 — with GitHub Actions Failure

update workflow to test against PR

064a126

Signed-off-by: sk593 <[email protected]>

sk593 force-pushed the update-validate-bicep-workflow branch from 07815dc to 064a126 Compare August 15, 2024 23:57

sk593 had a problem deploying to functional-tests August 15, 2024 23:58 — with GitHub Actions Failure

Merge branch 'main' into update-validate-bicep-workflow

f45366f

sk593 had a problem deploying to functional-tests August 19, 2024 17:08 — with GitHub Actions Failure

sk593 had a problem deploying to functional-tests August 19, 2024 18:10 — with GitHub Actions Failure

add check for warnings

49a0d2a

Signed-off-by: sk593 <[email protected]>

sk593 force-pushed the update-validate-bicep-workflow branch from 3b50c2c to 49a0d2a Compare August 19, 2024 18:28

sk593 had a problem deploying to functional-tests August 19, 2024 18:28 — with GitHub Actions Failure

Merge branch 'main' into update-validate-bicep-workflow

1284bd9

sk593 marked this pull request as ready for review August 20, 2024 17:16

sk593 requested review from a team as code owners August 20, 2024 17:16

sk593 temporarily deployed to functional-tests August 20, 2024 17:16 — with GitHub Actions Inactive

rynowak reviewed Aug 20, 2024

View reviewed changes

Merge branch 'main' into update-validate-bicep-workflow

f645354

sk593 temporarily deployed to functional-tests August 21, 2024 17:31 — with GitHub Actions Inactive

ytimocin approved these changes Aug 21, 2024

View reviewed changes

sk593 merged commit 33d3d5e into main Aug 21, 2024
30 checks passed

sk593 deleted the update-validate-bicep-workflow branch August 21, 2024 21:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update validate workflow to test against PR specific schema changes #7814

Update validate workflow to test against PR specific schema changes #7814

sk593 commented Aug 15, 2024

github-actions bot commented Aug 15, 2024 •

edited

Loading

codecov bot commented Aug 15, 2024 •

edited

Loading

radius-functional-tests bot commented Aug 20, 2024 •

edited

Loading

superbeeny commented Aug 20, 2024

rynowak Aug 20, 2024

sk593 Aug 20, 2024

rynowak Aug 21, 2024

rynowak Aug 20, 2024

sk593 Aug 20, 2024

rynowak Aug 20, 2024

sk593 commented Aug 20, 2024

radius-functional-tests bot commented Aug 21, 2024 •

edited

Loading

ytimocin Aug 21, 2024

Update validate workflow to test against PR specific schema changes #7814

Update validate workflow to test against PR specific schema changes #7814

Conversation

sk593 commented Aug 15, 2024

Description

Type of change

github-actions bot commented Aug 15, 2024 • edited Loading

Unit Tests

codecov bot commented Aug 15, 2024 • edited Loading

Codecov Report

radius-functional-tests bot commented Aug 20, 2024 • edited Loading

Radius functional test overview

Test Status

superbeeny commented Aug 20, 2024

rynowak Aug 20, 2024

Choose a reason for hiding this comment

sk593 Aug 20, 2024

Choose a reason for hiding this comment

rynowak Aug 21, 2024

Choose a reason for hiding this comment

rynowak Aug 20, 2024

Choose a reason for hiding this comment

sk593 Aug 20, 2024

Choose a reason for hiding this comment

rynowak Aug 20, 2024

Choose a reason for hiding this comment

sk593 commented Aug 20, 2024

radius-functional-tests bot commented Aug 21, 2024 • edited Loading

Radius functional test overview

Test Status

ytimocin Aug 21, 2024

Choose a reason for hiding this comment

github-actions bot commented Aug 15, 2024 •

edited

Loading

codecov bot commented Aug 15, 2024 •

edited

Loading

radius-functional-tests bot commented Aug 20, 2024 •

edited

Loading

radius-functional-tests bot commented Aug 21, 2024 •

edited

Loading