Updating the Radius installation step of the long-haul workflow #7008

ytimocin · 2024-01-10T07:22:10Z

Description

Added Report Failure step to the workflow.
Removed the secret deletion workaround step.

Details can be found here: #7007

Type of change

This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

radius-functional-tests · 2024-01-10T07:24:01Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	radius-project/radius
Commit ref	`edb8f15`
Unique ID	327dec3bed
Image tag	pr-327dec3bed

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-327dec3bed
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-327dec3bed
controller test image location: ghcr.io/radius-project/dev/controller:pr-327dec3bed
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-327dec3bed
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting daprrp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting samples functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting shared functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting ucp functional tests...
✅ msgrp functional tests succeeded
✅ samples functional tests succeeded
✅ kubernetes functional tests succeeded
✅ daprrp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ ucp functional tests succeeded
✅ shared functional tests succeeded

github-actions · 2024-01-10T07:32:54Z

Test Results

3 044 tests ±0 3 037 ✅ ±0 3m 29s ⏱️ +3s
261 suites ±0 7 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit f0bfc10. ± Comparison against base commit d7cdbf2.

♻️ This comment has been updated with latest results.

github-actions · 2024-01-10T07:33:18Z

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

Your PR branch coverage: 65.5 %
main branch coverage: 65.5 %
diff coverage: 0 %

The coverage result does not include the functional test coverage.

github-actions · 2024-01-10T23:00:27Z

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

Your PR branch coverage: 65.5 %
main branch coverage: 65.5 %
diff coverage: 0 %

The coverage result does not include the functional test coverage.

radius-functional-tests · 2024-01-10T23:15:50Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	radius-project/radius
Commit ref	`ca5b247`
Unique ID	b737712b1e
Image tag	pr-b737712b1e

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-b737712b1e
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-b737712b1e
controller test image location: ghcr.io/radius-project/dev/controller:pr-b737712b1e
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-b737712b1e
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting msgrp functional tests...
⌛ Starting samples functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting ucp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting datastoresrp functional tests...
✅ msgrp functional tests succeeded
✅ samples functional tests succeeded
✅ kubernetes functional tests succeeded
✅ daprrp functional tests succeeded
✅ ucp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ shared functional tests succeeded

radius-functional-tests · 2024-01-10T23:27:09Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	radius-project/radius
Commit ref	`66fa182`
Unique ID	138b32887d
Image tag	pr-138b32887d

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-138b32887d
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-138b32887d
controller test image location: ghcr.io/radius-project/dev/controller:pr-138b32887d
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-138b32887d
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting shared functional tests...
⌛ Starting samples functional tests...
⌛ Starting datastoresrp functional tests...
✅ msgrp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ samples functional tests succeeded
✅ ucp functional tests succeeded
✅ daprrp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ shared functional tests succeeded

github-actions · 2024-01-10T23:30:34Z

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

Your PR branch coverage: 65.5 %
main branch coverage: 65.5 %
diff coverage: 0 %

The coverage result does not include the functional test coverage.

youngbupark · 2024-01-10T23:35:56Z

.github/workflows/long-running-azure.yaml

+            exit 1
+          fi
+      - name: Set test run flag
+        run: kubectl create configmap long-running-test-lock -n radius-system


What if the clean up step in previous workflow run is failed? the current run will be ignored.

youngbupark · 2024-01-10T23:37:02Z

.github/workflows/long-running-azure.yaml

+          echo "*** Uninstalling existing Radius installation ***"
+          rad uninstall kubernetes
+
+          echo "*** Deleting radius-system namespace ***"
+          kubectl delete namespace radius-system --ignore-not-found


I do not think this is right approach. it is still workaround. upgrade scenario should work here.

github-actions · 2024-01-10T23:53:04Z

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

Your PR branch coverage: 65.5 %
main branch coverage: 65.5 %
diff coverage: 0 %

The coverage result does not include the functional test coverage.

deploy/Chart/templates/controller/webhook.yaml

radius-functional-tests · 2024-01-11T05:34:27Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	radius-project/radius
Commit ref	`fd6f57d`
Unique ID	6d4880aa54
Image tag	pr-6d4880aa54

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-6d4880aa54
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-6d4880aa54
controller test image location: ghcr.io/radius-project/dev/controller:pr-6d4880aa54
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-6d4880aa54
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting daprrp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting ucp functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting samples functional tests...
⌛ Starting shared functional tests...
⌛ Starting datastoresrp functional tests...
✅ kubernetes functional tests succeeded
✅ msgrp functional tests succeeded
✅ samples functional tests succeeded
✅ daprrp functional tests succeeded
✅ ucp functional tests succeeded
✅ datastoresrp functional tests succeeded
❌ shared functional test failed. Please check the logs for more details
⌛ Starting shared functional tests...
✅ shared functional tests succeeded

github-actions · 2024-01-11T05:37:57Z

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

Your PR branch coverage: 65.5 %
main branch coverage: 65.5 %
diff coverage: 0 %

The coverage result does not include the functional test coverage.

radius-functional-tests · 2024-01-16T16:28:25Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	radius-project/radius
Commit ref	`648e66b`
Unique ID	7683719ad4
Image tag	pr-7683719ad4

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-7683719ad4
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-7683719ad4
controller test image location: ghcr.io/radius-project/dev/controller:pr-7683719ad4
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-7683719ad4
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting samples functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting shared functional tests...
⌛ Starting ucp functional tests...
⌛ Starting datastoresrp functional tests...
✅ kubernetes functional tests succeeded
✅ samples functional tests succeeded
✅ msgrp functional tests succeeded
✅ ucp functional tests succeeded
✅ daprrp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ shared functional tests succeeded

github-actions · 2024-01-16T16:35:36Z

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

Your PR branch coverage: 65.7 %
main branch coverage: 65.7 %
diff coverage: 0 %

The coverage result does not include the functional test coverage.

Signed-off-by: ytimocin <[email protected]>

ytimocin · 2024-01-16T17:12:30Z

deploy/Chart/templates/controller/validating-webhook-configuration.yaml

@@ -13,7 +13,6 @@ metadata:
  labels:
    app.kubernetes.io/name: controller
    app.kubernetes.io/part-of: radius
-type: kubernetes.io/tls


Got this error: error updating the resource "ucp-cert": cannot patch "ucp-cert" with kind Secret: Secret "ucp-cert" is invalid: type: Invalid value: "kubernetes.io/tls": field is immutable.

If we do a release with this update, it might affect customers who have previous installations and want to do a reinstall by any chance. Would like to hear more thoughts on this.

Created this issue: #7035.

github-actions · 2024-01-16T17:19:15Z

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

Your PR branch coverage: 65.7 %
main branch coverage: 65.7 %
diff coverage: 0 %

The coverage result does not include the functional test coverage.

radius-functional-tests · 2024-01-16T17:28:03Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	radius-project/radius
Commit ref	`f0bfc10`
Unique ID	6e3ab42606
Image tag	pr-6e3ab42606

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-6e3ab42606
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-6e3ab42606
controller test image location: ghcr.io/radius-project/dev/controller:pr-6e3ab42606
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-6e3ab42606
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting shared functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting samples functional tests...
⌛ Starting kubernetes functional tests...
✅ msgrp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ samples functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ ucp functional tests succeeded
✅ daprrp functional tests succeeded
✅ shared functional tests succeeded

lakshmimsft · 2024-01-16T22:45:06Z

as discussed, secrets continue to be 'opaque' as they were earlier.

…us-project#7008) # Description * Added **Report Failure** step to the workflow. * Removed the secret deletion workaround step. Details can be found here: radius-project#7007 ## Type of change - This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional). Signed-off-by: ytimocin <[email protected]> Signed-off-by: willdavsmith <[email protected]>

…us-project#7008) * Added **Report Failure** step to the workflow. * Removed the secret deletion workaround step. Details can be found here: radius-project#7007 - This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional). Signed-off-by: ytimocin <[email protected]>

…us-project#7008) # Description * Added **Report Failure** step to the workflow. * Removed the secret deletion workaround step. Details can be found here: radius-project#7007 ## Type of change - This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional). Signed-off-by: ytimocin <[email protected]>

ytimocin had a problem deploying to functional-tests January 10, 2024 07:22 — with GitHub Actions Failure

ytimocin force-pushed the ytimocin/updateLongHaulWorkflow branch from 4e011b1 to edb8f15 Compare January 10, 2024 07:22

ytimocin temporarily deployed to functional-tests January 10, 2024 07:22 — with GitHub Actions Inactive

ytimocin force-pushed the ytimocin/updateLongHaulWorkflow branch from edb8f15 to 301c46f Compare January 10, 2024 22:52

ytimocin had a problem deploying to functional-tests January 10, 2024 22:52 — with GitHub Actions Failure

ytimocin marked this pull request as ready for review January 10, 2024 22:52

ytimocin requested review from a team as code owners January 10, 2024 22:52

ytimocin force-pushed the ytimocin/updateLongHaulWorkflow branch from 301c46f to ca5b247 Compare January 10, 2024 23:14

ytimocin temporarily deployed to functional-tests January 10, 2024 23:14 — with GitHub Actions Inactive

ytimocin force-pushed the ytimocin/updateLongHaulWorkflow branch from ca5b247 to 66fa182 Compare January 10, 2024 23:22

ytimocin temporarily deployed to functional-tests January 10, 2024 23:22 — with GitHub Actions Inactive

youngbupark reviewed Jan 10, 2024

View reviewed changes

ytimocin force-pushed the ytimocin/updateLongHaulWorkflow branch from 66fa182 to 647467b Compare January 10, 2024 23:44

ytimocin had a problem deploying to functional-tests January 10, 2024 23:44 — with GitHub Actions Failure

This was referenced Jan 11, 2024

Scheduled long running test failed - Run ID: 7482148731 #7014

Closed

Scheduled long running test failed - Run ID: 7481983492 #7012

Closed

ytimocin force-pushed the ytimocin/updateLongHaulWorkflow branch from 647467b to fd6f57d Compare January 11, 2024 05:29

ytimocin temporarily deployed to functional-tests January 11, 2024 05:29 — with GitHub Actions Inactive

ytimocin commented Jan 11, 2024

View reviewed changes

deploy/Chart/templates/controller/webhook.yaml Outdated Show resolved Hide resolved

ytimocin requested review from youngbupark and rynowak January 11, 2024 05:32

ytimocin requested a review from lakshmimsft January 11, 2024 05:32

ytimocin force-pushed the ytimocin/updateLongHaulWorkflow branch from fd6f57d to dabb402 Compare January 16, 2024 16:26

ytimocin had a problem deploying to functional-tests January 16, 2024 16:26 — with GitHub Actions Failure

ytimocin force-pushed the ytimocin/updateLongHaulWorkflow branch from dabb402 to 648e66b Compare January 16, 2024 16:26

ytimocin temporarily deployed to functional-tests January 16, 2024 16:27 — with GitHub Actions Inactive

Updating the Radius installation step of the long-haul workflow

f0bfc10

Signed-off-by: ytimocin <[email protected]>

ytimocin force-pushed the ytimocin/updateLongHaulWorkflow branch from 648e66b to f0bfc10 Compare January 16, 2024 17:11

ytimocin temporarily deployed to functional-tests January 16, 2024 17:11 — with GitHub Actions Inactive

ytimocin commented Jan 16, 2024

View reviewed changes

lakshmimsft approved these changes Jan 16, 2024

View reviewed changes

ytimocin merged commit 90a9b1e into main Jan 16, 2024
22 checks passed

ytimocin deleted the ytimocin/updateLongHaulWorkflow branch January 16, 2024 23:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updating the Radius installation step of the long-haul workflow #7008

Updating the Radius installation step of the long-haul workflow #7008

ytimocin commented Jan 10, 2024 •

edited

Loading

radius-functional-tests bot commented Jan 10, 2024 •

edited

Loading

github-actions bot commented Jan 10, 2024 •

edited

Loading

github-actions bot commented Jan 10, 2024

github-actions bot commented Jan 10, 2024

radius-functional-tests bot commented Jan 10, 2024 •

edited

Loading

radius-functional-tests bot commented Jan 10, 2024 •

edited

Loading

github-actions bot commented Jan 10, 2024

youngbupark Jan 10, 2024

youngbupark Jan 10, 2024

github-actions bot commented Jan 10, 2024

radius-functional-tests bot commented Jan 11, 2024 •

edited

Loading

github-actions bot commented Jan 11, 2024

radius-functional-tests bot commented Jan 16, 2024 •

edited

Loading

github-actions bot commented Jan 16, 2024

ytimocin Jan 16, 2024

ytimocin Jan 16, 2024

github-actions bot commented Jan 16, 2024

radius-functional-tests bot commented Jan 16, 2024 •

edited

Loading

lakshmimsft commented Jan 16, 2024

Updating the Radius installation step of the long-haul workflow #7008

Updating the Radius installation step of the long-haul workflow #7008

Conversation

ytimocin commented Jan 10, 2024 • edited Loading

Description

Type of change

radius-functional-tests bot commented Jan 10, 2024 • edited Loading

Radius functional test overview

Test Status

github-actions bot commented Jan 10, 2024 • edited Loading

Test Results

github-actions bot commented Jan 10, 2024

github-actions bot commented Jan 10, 2024

radius-functional-tests bot commented Jan 10, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Jan 10, 2024 • edited Loading

Radius functional test overview

Test Status

github-actions bot commented Jan 10, 2024

youngbupark Jan 10, 2024

Choose a reason for hiding this comment

youngbupark Jan 10, 2024

Choose a reason for hiding this comment

github-actions bot commented Jan 10, 2024

radius-functional-tests bot commented Jan 11, 2024 • edited Loading

Radius functional test overview

Test Status

github-actions bot commented Jan 11, 2024

radius-functional-tests bot commented Jan 16, 2024 • edited Loading

Radius functional test overview

Test Status

github-actions bot commented Jan 16, 2024

ytimocin Jan 16, 2024

Choose a reason for hiding this comment

ytimocin Jan 16, 2024

Choose a reason for hiding this comment

github-actions bot commented Jan 16, 2024

radius-functional-tests bot commented Jan 16, 2024 • edited Loading

Radius functional test overview

Test Status

lakshmimsft commented Jan 16, 2024

ytimocin commented Jan 10, 2024 •

edited

Loading

radius-functional-tests bot commented Jan 10, 2024 •

edited

Loading

github-actions bot commented Jan 10, 2024 •

edited

Loading

radius-functional-tests bot commented Jan 10, 2024 •

edited

Loading

radius-functional-tests bot commented Jan 10, 2024 •

edited

Loading

radius-functional-tests bot commented Jan 11, 2024 •

edited

Loading

radius-functional-tests bot commented Jan 16, 2024 •

edited

Loading

radius-functional-tests bot commented Jan 16, 2024 •

edited

Loading