-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update error message in LRT for bicep recipe language failure #7809
Labels
bug
Something is broken or not working as expected
Comments
👋 @sk593 Thanks for filing this bug report. A project maintainer will review this report and get back to you soon. If you'd like immediate help troubleshooting, please visit our Discord server. For more information on our triage process please visit our triage overview |
sk593
added a commit
that referenced
this issue
Aug 14, 2024
# Description This updates the error message checked in the bicep language failure check. There's a character mismatch in the two templates that get deployed in the func tests vs the LRT. The error message is coded towards the func tests so the character mismatch causes the LRT to fail ## Type of change <!-- Please select **one** of the following options that describes your change and delete the others. Clearly identifying the type of change you are making will help us review your PR faster, and is used in authoring release notes. If you are making a bug fix or functionality change to Radius and do not have an associated issue link please create one now. --> - This pull request fixes a bug in Radius and has an approved issue (issue link required). - This pull request adds or changes features of Radius and has an approved issue (issue link required). - This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional). <!-- Please update the following to link the associated issue. This is required for some kinds of changes (see above). --> Fixes: #7809 --------- Signed-off-by: sk593 <[email protected]>
Reshrahim
pushed a commit
to Reshrahim/radius
that referenced
this issue
Aug 27, 2024
# Description This updates the error message checked in the bicep language failure check. There's a character mismatch in the two templates that get deployed in the func tests vs the LRT. The error message is coded towards the func tests so the character mismatch causes the LRT to fail ## Type of change <!-- Please select **one** of the following options that describes your change and delete the others. Clearly identifying the type of change you are making will help us review your PR faster, and is used in authoring release notes. If you are making a bug fix or functionality change to Radius and do not have an associated issue link please create one now. --> - This pull request fixes a bug in Radius and has an approved issue (issue link required). - This pull request adds or changes features of Radius and has an approved issue (issue link required). - This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional). <!-- Please update the following to link the associated issue. This is required for some kinds of changes (see above). --> Fixes: radius-project#7809 --------- Signed-off-by: sk593 <[email protected]> Signed-off-by: Reshma Abdul Rahim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps to reproduce
There's a failure in the LRT due to a mismatch in the error message in a negative test. The mismatch is due to the length of characters used in the version number for the recipe published. The test is coded to match the number of characters in the functional test (i.e. pr-func#) but the LRT use "latest" as the version number so there's an index mismatch
Observed behavior
Desired behavior
Update the test to either check for the specific index or to ignore the index and shorten the message that gets validated
Workaround
No response
rad Version
GH action run
Operating system
No response
Additional context
No response
Would you like to support us?
AB#12968
The text was updated successfully, but these errors were encountered: