Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove/disable assets workflow #7800

Closed
1 task
sk593 opened this issue Aug 12, 2024 · 5 comments · Fixed by #7832
Closed
1 task

Remove/disable assets workflow #7800

sk593 opened this issue Aug 12, 2024 · 5 comments · Fixed by #7832
Assignees
Labels
bug Something is broken or not working as expected triaged This issue has been reviewed and triaged

Comments

@sk593
Copy link
Contributor

sk593 commented Aug 12, 2024

Steps to reproduce

The assets workflow has started to fail. We don't use any of the assets that get uploaded so these should be disabled and/or removed: https://github.com/radius-project/radius/blob/main/.github/workflows/assets.yaml

Observed behavior

No response

Desired behavior

Either we disable and eventually delete the workflow or we update the workflow so it passes. We don't pull assets from Azure storage anymore so this shouldn't be needed

Workaround

No response

rad Version

GH actions runs

Operating system

No response

Additional context

No response

Would you like to support us?

  • Yes, I would like to support you

AB#12960

@sk593 sk593 added the bug Something is broken or not working as expected label Aug 12, 2024
@radius-triage-bot
Copy link

👋 @sk593 Thanks for filing this bug report.

A project maintainer will review this report and get back to you soon. If you'd like immediate help troubleshooting, please visit our Discord server.

For more information on our triage process please visit our triage overview

@ytimocin
Copy link
Contributor

Related issue: #7780.

@ytimocin
Copy link
Contributor

I think removing is the way to go if we are sure that the assets generated are not being used. cc/ @willdavsmith

@lakshmimsft lakshmimsft self-assigned this Aug 12, 2024
@sk593
Copy link
Contributor Author

sk593 commented Aug 13, 2024

We've disabled this for now. We'll go ahead with the delete if there's no unexpected issues

@lakshmimsft lakshmimsft added the triaged This issue has been reviewed and triaged label Aug 15, 2024
@radius-triage-bot
Copy link

👍 We've reviewed this issue and have agreed to add it to our backlog. Please subscribe to this issue for notifications, we'll provide updates when we pick it up.

We also welcome community contributions! If you would like to pick this item up sooner and submit a pull request, please visit our contribution guidelines and assign this to yourself by commenting "/assign" on this issue.

For more information on our triage process please visit our triage overview

Reshrahim pushed a commit to Reshrahim/radius that referenced this issue Aug 27, 2024
# Description

Cleaning up disabled workflow assets.yaml.

## Type of change
- This pull request is a minor refactor, code cleanup, test improvement,
or other maintenance task and doesn't change the functionality of Radius
(radius-project#7800 ).

Fixes: radius-project#7800
Signed-off-by: Reshma Abdul Rahim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken or not working as expected triaged This issue has been reviewed and triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants