-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bad error message when showing recipes in ACR #6902
Comments
👋 @Gijsreyn Thanks for filing this bug report. A project maintainer will review this report and get back to you soon. If you'd like immediate help troubleshooting, please visit our Discord server. For more information on our triage process please visit our triage overview |
Thanks @Gijsreyn for submitting this issue. We will look into this shortly. |
Would love to see it. Was trying to setup a demo from an operator perspective, but couldn't go further with the diagnostics Radius is proving. |
👍 We've reviewed this issue and have agreed to add it to our backlog. Please subscribe to this issue for notifications, we'll provide updates when we pick it up. We also welcome community contributions! If you would like to pick this item up sooner and submit a pull request, please visit our contribution guidelines and assign this to yourself by commenting "/assign" on this issue. For more information on our triage process please visit our triage overview |
This issue is a great one to pickup for new contributors. It should only require small changes and not assume a deep knowledge of the Radius architecture. We always welcome community contributions! If you would like to pick this item up sooner and submit a pull request, please visit our contribution guidelines and assign this to yourself by commenting "/assign" on this issue. For more information on our triage process please visit our triage overview |
@vinayada1 , may this be related to #6917 ? |
@Gijsreyn , thats correct. Today we only allow OCI registries with anonymous pull enabled as Bicep registries for Recipes. I wonder if the registry used was configured with private access that causing this issue. |
I probably think that's the case. I removed my demo, so I have to set it up again. Anyways, thanks for the reply! |
For reference for anyone searching... Installing Azure CLI
LoginLogin to Azure using the CLI. Note that if you are using Devcontainers then you will need to use the "use-device-code" flag. az login
az login --use-device-code Login ACRNext we login to the ACR az acr login -n <acr-name>.azurecr.io Publish our RecipeNext we publish out Recipe rad bicep publish --file <bicep-file> --target "br:<acr-name>.azurecr.io/<image>:<tag>" |
# Description Improve error message returned when publishing to a private ACR ## Type of change <!-- Please select **one** of the following options that describes your change and delete the others. Clearly identifying the type of change you are making will help us review your PR faster, and is used in authoring release notes. If you are making a bug fix or functionality change to Radius and do not have an associated issue link please create one now. --> - This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional). <!-- Please update the following to link the associated issue. This is required for some kinds of changes (see above). --> Fixes: #6902 #6297 ## Auto-generated summary <!-- GitHub Copilot for docs will auto-generate a summary of the PR --> copilot:all --------- Signed-off-by: Garry Taylor <[email protected]> Co-authored-by: Ryan Nowak <[email protected]>
I'm reopening this because I'm not sure that #6974 addressed it. That PR improves the error message for pushes to a registry ( |
|
Hi, Just had some time to setup the demo again. This is what I'm trying to do: az login In the oci.bicep file: @description('Required. The Azure Container Registry')
param name string
@description('Optional. Provide a location for the registry.')
param location string = resourceGroup().location
@description('Optional. Provide a tier of your Azure Container Registry.')
param sku string = 'Basic'
resource acrResource 'Microsoft.ContainerRegistry/registries@2023-01-01-preview' = {
name: name
location: location
sku: {
name: sku
}
properties: {
adminUserEnabled: false
}
}
@description('Output the login server property for later use')
output loginServer string = acrResource.properties.loginServer Still getting authentication required. |
hi @Gijsreyn thank you for the detailed response.
You can then Push/publish to this ACR. Let me know how you get on. @rynowak this is what I meant in my comment. The issue is with "publish" not "show" |
Successfully published Bicep file "sqlfile.bicep" to "acrradius.azurecr.io/azure/sql:latest" No error message this time. |
Great! Can you please #close this ticket if you're happy everything is working? |
…ect#6974) # Description Improve error message returned when publishing to a private ACR ## Type of change <!-- Please select **one** of the following options that describes your change and delete the others. Clearly identifying the type of change you are making will help us review your PR faster, and is used in authoring release notes. If you are making a bug fix or functionality change to Radius and do not have an associated issue link please create one now. --> - This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional). <!-- Please update the following to link the associated issue. This is required for some kinds of changes (see above). --> Fixes: radius-project#6902 radius-project#6297 ## Auto-generated summary <!-- GitHub Copilot for docs will auto-generate a summary of the PR --> copilot:all --------- Signed-off-by: Garry Taylor <[email protected]> Co-authored-by: Ryan Nowak <[email protected]> Signed-off-by: willdavsmith <[email protected]>
Bug information
Steps to reproduce (required)
rad bicep publish
Observed behavior (required)
Desired behavior (required)
A better error message that explains the problem and tells you how to login to pull. If I were an external customer I wouldn't be sure how to fix this.
AB#10641
The text was updated successfully, but these errors were encountered: