make disconnects safer

radioactive-labs · Feb 4, 2025 · b626c07 · b626c07
1 parent cd2f1a1
commit b626c07
Show file tree

Hide file tree

Showing 9 changed files with 37 additions and 22 deletions.
diff --git a/app/assets/plutonium.js b/app/assets/plutonium.js
@@ -11161,8 +11161,10 @@ ${text2}</tr>
       this.element.setAttribute("data-action", "turbo:morph-element->easymde#reconnect");
     }
     disconnect() {
-      this.easyMDE.toTextArea();
-      this.easyMDE = null;
+      if (this.easyMDE) {
+        this.easyMDE.toTextArea();
+        this.easyMDE = null;
+      }
     }
     reconnect() {
       this.disconnect();
@@ -11203,8 +11205,10 @@ ${text2}</tr>
       this.element.setAttribute("data-action", "turbo:morph-element->slim-select#reconnect");
     }
     disconnect() {
-      this.slimSelect.destroy();
-      this.slimSelect = null;
+      if (this.slimSelect) {
+        this.slimSelect.destroy();
+        this.slimSelect = null;
+      }
     }
     reconnect() {
       this.disconnect();
@@ -11219,8 +11223,10 @@ ${text2}</tr>
       this.element.setAttribute("data-action", "turbo:morph-element->flatpickr#reconnect");
     }
     disconnect() {
-      this.picker.destroy();
-      this.picker = null;
+      if (this.picker) {
+        this.picker.destroy();
+        this.picker = null;
+      }
     }
     reconnect() {
       this.disconnect();
@@ -11253,9 +11259,10 @@ ${text2}</tr>
       this.inputTarget.setAttribute("data-action", "turbo:morph-element->intl-tel-input#reconnect");
     }
     inputTargetDisconnected() {
-      if (this.iti)
+      if (this.iti) {
         this.iti.destroy();
-      this.iti = null;
+        this.iti = null;
+      }
     }
     reconnect() {
       this.inputTargetDisconnected();

diff --git a/app/assets/plutonium.js.map b/app/assets/plutonium.js.map
diff --git a/app/assets/plutonium.min.js b/app/assets/plutonium.min.js
diff --git a/app/assets/plutonium.min.js.map b/app/assets/plutonium.min.js.map
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@radioactive-labs/plutonium",
-  "version": "0.3.2",
+  "version": "0.3.3",
   "description": "Core assets for the Plutonium gem",
   "type": "module",
   "main": "src/js/core.js",

diff --git a/src/js/controllers/easymde_controller.js b/src/js/controllers/easymde_controller.js
@@ -10,8 +10,10 @@ export default class extends Controller {
   }
 
   disconnect() {
-    this.easyMDE.toTextArea()
-    this.easyMDE = null
+    if (this.easyMDE) {
+      this.easyMDE.toTextArea()
+      this.easyMDE = null
+    }
   }
 
   reconnect() {

diff --git a/src/js/controllers/flatpickr_controller.js b/src/js/controllers/flatpickr_controller.js
@@ -8,8 +8,10 @@ export default class extends Controller {
   }
 
   disconnect() {
-    this.picker.destroy()
-    this.picker = null
+    if (this.picker) {
+      this.picker.destroy()
+      this.picker = null
+    }
   }
 
   reconnect() {

diff --git a/src/js/controllers/intl_tel_input_controller.js b/src/js/controllers/intl_tel_input_controller.js
@@ -19,8 +19,10 @@ export default class extends Controller {
   }
 
   inputTargetDisconnected() {
-    if (this.iti) this.iti.destroy()
-    this.iti = null
+    if (this.iti) {
+      this.iti.destroy()
+      this.iti = null
+    }
   }
 
   reconnect() {

diff --git a/src/js/controllers/slim_select_controller.js b/src/js/controllers/slim_select_controller.js
@@ -10,8 +10,10 @@ export default class extends Controller {
   }
 
   disconnect() {
-    this.slimSelect.destroy()
-    this.slimSelect = null
+    if (this.slimSelect) {
+      this.slimSelect.destroy()
+      this.slimSelect = null
+    }
   }
 
   reconnect() {