Bugfix: __len__ test for beams #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you write out a non-varying-spectral-resolution spectrum, it will try to load in as a VRS because the `hasattr(beam, '__len__')` check is true, even though there is no `len`.
keflavich
force-pushed
the
fix_beam_len_check
branch
from
5ec7a68 to
94791ea
Compare
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #852 +/- ##
=======================================
Coverage 77.36% 77.36%
=======================================
Files 24 24
Lines 6025 6027 +2
=======================================
+ Hits 4661 4663 +2
Misses 1364 1364
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Test failures are unrelated to this change. We'll fix in a separate PR (starting in #868) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you write out a non-varying-spectral-resolution spectrum, it will try to load in as a VRS because the
hasattr(beam, '__len__')check is true, even though there is nolen.