Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search context #633

Merged
merged 6 commits into from
Nov 7, 2019
Merged

Search context #633

merged 6 commits into from
Nov 7, 2019

Conversation

matthewhanson
Copy link
Collaborator

Related Issue(s): #
#592

Proposed Changes:

  1. Rename search API extension to context
  2. Change search:metadata field to context

PR Checklist:

  • This PR has no breaking changes.
  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.
  • API only: I have run npm run generate-all to update the generated OpenAPI files.

Copy link
Collaborator

@m-mohr m-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor issue (see the other comment), other than that looks good.

Copy link
Contributor

@hgs-msmith hgs-msmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with Matthias' request.

@joshfix joshfix merged commit 1fdaf20 into dev Nov 7, 2019
@m-mohr m-mohr deleted the search_context branch November 7, 2019 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants