Refactor common parts of the spec #1203 #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-mohr
force-pushed
the
issue1203
branch
2 times, most recently
from
3d9fe17 to
f70ff99
Compare
m-mohr
requested review from
gadomski,
cholmes,
emmanuelmathot,
matthewhanson,
lossyrob and
jbants
There was a problem hiding this comment.
Maybe the In this Repository section of the README should have an entry to the new common parts.
|
Good idea, I also added a README to the commons folder. |
emmanuelmathot
approved these changes
Aug 6, 2024
gadomski
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s): #1203
Proposed Changes:
The changes should be editorial only.
PR Checklist:
or a CHANGELOG entry is not required.
and I have opened issue/PR #XXX to track the change.